New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Response __debugInfo() to get body content #11403

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
3 participants
@cleptric
Member

cleptric commented Nov 3, 2017

Currently, debugging the response, always returns 'body' => ''.
I added a type cast and updated the test.

@cleptric cleptric added the Defect label Nov 3, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 3, 2017

Codecov Report

Merging #11403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11403      +/-   ##
============================================
+ Coverage     93.11%   93.12%   +<.01%     
  Complexity    13006    13006              
============================================
  Files           436      436              
  Lines         33695    33695              
============================================
+ Hits          31374    31377       +3     
+ Misses         2321     2318       -3
Impacted Files Coverage Δ Complexity Δ
src/Http/Response.php 93.69% <100%> (ø) 258 <0> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.61% <0%> (+4.25%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042d0cd...7ee9d21. Read the comment docs.

codecov-io commented Nov 3, 2017

Codecov Report

Merging #11403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11403      +/-   ##
============================================
+ Coverage     93.11%   93.12%   +<.01%     
  Complexity    13006    13006              
============================================
  Files           436      436              
  Lines         33695    33695              
============================================
+ Hits          31374    31377       +3     
+ Misses         2321     2318       -3
Impacted Files Coverage Δ Complexity Δ
src/Http/Response.php 93.69% <100%> (ø) 258 <0> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.61% <0%> (+4.25%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042d0cd...7ee9d21. Read the comment docs.

@markstory markstory added this to the 3.5.6 milestone Nov 3, 2017

@markstory markstory merged commit 0d51a48 into master Nov 3, 2017

6 checks passed

codecov/patch 100% of diff hit (target 93.11%)
Details
codecov/project 93.12% (+<.01%) compared to 042d0cd
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory deleted the response-debug branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment