New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate subdirectories for file type views. #11411

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@markstory
Member

markstory commented Nov 7, 2017

When a template path ends with the current subDir property we shouldn't re-apply that subDir as it will result in bad paths.

Refs #11316

Fix duplicate subdirectories for file type views.
When a template path ends with the current subDir property we shouldn't
re-apply that subDir as it will result in bad paths.

Refs #11316

@markstory markstory added this to the 3.5.6 milestone Nov 7, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 7, 2017

Codecov Report

Merging #11411 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11411      +/-   ##
============================================
+ Coverage     93.11%   93.12%   +0.01%     
- Complexity    13007    13008       +1     
============================================
  Files           436      436              
  Lines         33697    33699       +2     
============================================
+ Hits          31376    31383       +7     
+ Misses         2321     2316       -5
Impacted Files Coverage Δ Complexity Δ
src/View/View.php 91.24% <100%> (+0.04%) 155 <0> (+1) ⬆️
src/Cache/Engine/FileEngine.php 90.16% <0%> (+1.09%) 73% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.61% <0%> (+4.25%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e3179...115a354. Read the comment docs.

codecov-io commented Nov 7, 2017

Codecov Report

Merging #11411 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11411      +/-   ##
============================================
+ Coverage     93.11%   93.12%   +0.01%     
- Complexity    13007    13008       +1     
============================================
  Files           436      436              
  Lines         33697    33699       +2     
============================================
+ Hits          31376    31383       +7     
+ Misses         2321     2316       -5
Impacted Files Coverage Δ Complexity Δ
src/View/View.php 91.24% <100%> (+0.04%) 155 <0> (+1) ⬆️
src/Cache/Engine/FileEngine.php 90.16% <0%> (+1.09%) 73% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.61% <0%> (+4.25%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e3179...115a354. Read the comment docs.

@markstory markstory merged commit 051db94 into master Nov 9, 2017

6 checks passed

codecov/patch 100% of diff hit (target 93.11%)
Details
codecov/project 93.12% (+0.01%) compared to e6e3179
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@josegonzalez josegonzalez deleted the issue-11316 branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment