New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing url encoding to protocol relative URLs #11430

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
2 participants
@markstory
Member

markstory commented Nov 15, 2017

Protocol relative URLs were missed from the changes in #11092 as they are handled by a different code branch.

Add missing url encoding to protocol relative URLs
Protocol relative URLs were missed from the changes in #11092 as they
are handled by a different code branch.

@markstory markstory added the helpers label Nov 15, 2017

@markstory markstory added this to the 3.5.6 milestone Nov 15, 2017

@markstory markstory self-assigned this Nov 15, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 15, 2017

Codecov Report

Merging #11430 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11430   +/-   ##
=========================================
  Coverage     93.11%   93.11%           
  Complexity    13008    13008           
=========================================
  Files           436      436           
  Lines         33697    33697           
=========================================
  Hits          31377    31377           
  Misses         2320     2320
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/UrlHelper.php 96.62% <100%> (ø) 38 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600e90d...e1d4bc1. Read the comment docs.

codecov-io commented Nov 15, 2017

Codecov Report

Merging #11430 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11430   +/-   ##
=========================================
  Coverage     93.11%   93.11%           
  Complexity    13008    13008           
=========================================
  Files           436      436           
  Lines         33697    33697           
=========================================
  Hits          31377    31377           
  Misses         2320     2320
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/UrlHelper.php 96.62% <100%> (ø) 38 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600e90d...e1d4bc1. Read the comment docs.

@markstory markstory merged commit 7d16172 into master Nov 17, 2017

6 checks passed

codecov/patch 100% of diff hit (target 93.11%)
Details
codecov/project 93.11% (+0%) compared to 600e90d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory deleted the urlbuilder-escape branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment