Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add confirm message for form buttons. #11483
Inside normal HTML using postLink() and confirm messages work fine.
<?= $this->Form->button(__('Finalize'), ['confirm' => 'Make sure ... before you continue.'] ?> <?= $this->Form->end() ?>
Also works for postButton() then, of course, as standalone forms:
<?= $this->Form->postButton('Click', ['action' => 'foo', 'bar'], ['confirm' => 'Yeah?']) ?>
Not sure about the "old"
@@ Coverage Diff @@ ## master #11483 +/- ## ============================================ + Coverage 93.1% 93.38% +0.28% - Complexity 13014 13015 +1 ============================================ Files 436 436 Lines 33761 32751 -1010 ============================================ - Hits 31433 30586 -847 + Misses 2328 2165 -163
@ADmad As long as we do not have a good concept to move away from the already existing functionality, completing it is a must-have IMO :)
Once there is a concept for it, we can easily then migrate all of them together with a future major version jump.