New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email config for transferEncoding #11485 #11488

Merged
merged 7 commits into from Dec 6, 2017

Conversation

@LifeOrYou
Contributor

LifeOrYou commented Dec 1, 2017

Add getter/setter for transferEncoding and modify the _getContentTranferEncoding for use transferEncoding if is set.

Write test in EmailTest for check it.

Show outdated Hide outdated src/Mailer/Email.php Outdated
Show outdated Hide outdated src/Mailer/Email.php Outdated
Show outdated Hide outdated tests/TestCase/Mailer/EmailTest.php Outdated
Show outdated Hide outdated tests/TestCase/Mailer/EmailTest.php Outdated
Show outdated Hide outdated src/Mailer/Email.php Outdated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 1, 2017

Codecov Report

Merging #11488 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11488      +/-   ##
============================================
+ Coverage     93.37%   93.39%   +0.01%     
- Complexity    13015    13019       +4     
============================================
  Files           436      436              
  Lines         32751    32765      +14     
============================================
+ Hits          30582    30600      +18     
+ Misses         2169     2165       -4
Impacted Files Coverage Δ Complexity Δ
src/Mailer/Email.php 97.26% <100%> (+0.04%) 332 <3> (+4) ⬆️
src/Cache/Engine/FileEngine.php 90.1% <0%> (+1.09%) 73% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.47% <0%> (+2.17%) 19% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4.16%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cf3e7...3a75517. Read the comment docs.

codecov-io commented Dec 1, 2017

Codecov Report

Merging #11488 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11488      +/-   ##
============================================
+ Coverage     93.37%   93.39%   +0.01%     
- Complexity    13015    13019       +4     
============================================
  Files           436      436              
  Lines         32751    32765      +14     
============================================
+ Hits          30582    30600      +18     
+ Misses         2169     2165       -4
Impacted Files Coverage Δ Complexity Δ
src/Mailer/Email.php 97.26% <100%> (+0.04%) 332 <3> (+4) ⬆️
src/Cache/Engine/FileEngine.php 90.1% <0%> (+1.09%) 73% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.47% <0%> (+2.17%) 19% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4.16%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cf3e7...3a75517. Read the comment docs.

Show outdated Hide outdated src/Mailer/Email.php Outdated

@markstory markstory self-assigned this Dec 1, 2017

@markstory markstory added this to the 3.5.7 milestone Dec 1, 2017

@LifeOrYou

This comment has been minimized.

Show comment
Hide comment
@LifeOrYou

LifeOrYou Dec 1, 2017

Contributor

Is possible add this pull request for cakephp v3.4.x or is only for 3.5.x ?

Contributor

LifeOrYou commented Dec 1, 2017

Is possible add this pull request for cakephp v3.4.x or is only for 3.5.x ?

@markstory

This comment has been minimized.

Show comment
Hide comment
@markstory

markstory Dec 2, 2017

Member

Is possible add this pull request for cakephp v3.4.x or is only for 3.5.x ?

We're only doing security fixes for 3.4 at this point in time. The upgrade from 3.4 to 3.5 should be pretty painless if you need this in your app.

Member

markstory commented Dec 2, 2017

Is possible add this pull request for cakephp v3.4.x or is only for 3.5.x ?

We're only doing security fixes for 3.4 at this point in time. The upgrade from 3.4 to 3.5 should be pretty painless if you need this in your app.

* @param string|null $encoding Encoding set.
* @return $this
*/
public function setTransferEncoding($encoding)

This comment has been minimized.

@markstory

markstory Dec 2, 2017

Member

Should we be handling encoding the message based on the indicated transfer encoding? Right now someone could set the transfer encoding to base64, but the email message will still be in 8bit (generally).

@markstory

markstory Dec 2, 2017

Member

Should we be handling encoding the message based on the indicated transfer encoding? Right now someone could set the transfer encoding to base64, but the email message will still be in 8bit (generally).

This comment has been minimized.

@LifeOrYou

LifeOrYou Dec 6, 2017

Contributor

I think they are two different parts. I don't know if have a link between transfer encoding and message encoding.

@LifeOrYou

LifeOrYou Dec 6, 2017

Contributor

I think they are two different parts. I don't know if have a link between transfer encoding and message encoding.

This comment has been minimized.

@markstory

markstory Dec 6, 2017

Member

Ok.

@markstory

markstory Dec 6, 2017

Member

Ok.

@markstory markstory modified the milestones: 3.5.7, 3.5.8 Dec 6, 2017

@markstory markstory merged commit e7f5da5 into cakephp:master Dec 6, 2017

5 checks passed

codecov/patch 100% of diff hit (target 93.37%)
Details
codecov/project 93.39% (+0.01%) compared to d7cf3e7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory referenced this pull request Dec 12, 2017

Closed

Unable to send email with DKIM signature #11485

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment