New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect triggering of callable strings #11502

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@chinpei215
Member

chinpei215 commented Dec 4, 2017

No description provided.

@chinpei215 chinpei215 added the Defect label Dec 4, 2017

@chinpei215 chinpei215 added this to the 3.5.7 milestone Dec 4, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 4, 2017

Codecov Report

Merging #11502 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11502      +/-   ##
============================================
- Coverage     93.38%   93.37%   -0.01%     
- Complexity    13016    13017       +1     
============================================
  Files           436      436              
  Lines         32753    32753              
============================================
- Hits          30586    30584       -2     
- Misses         2167     2169       +2
Impacted Files Coverage Δ Complexity Δ
src/Http/Response.php 93.81% <100%> (ø) 259 <0> (+1) ⬆️
src/Cache/CacheRegistry.php 95.83% <0%> (-4.17%) 11% <0%> (ø)
src/Cache/CacheEngine.php 91.3% <0%> (-2.18%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf426d...c68a773. Read the comment docs.

codecov-io commented Dec 4, 2017

Codecov Report

Merging #11502 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11502      +/-   ##
============================================
- Coverage     93.38%   93.37%   -0.01%     
- Complexity    13016    13017       +1     
============================================
  Files           436      436              
  Lines         32753    32753              
============================================
- Hits          30586    30584       -2     
- Misses         2167     2169       +2
Impacted Files Coverage Δ Complexity Δ
src/Http/Response.php 93.81% <100%> (ø) 259 <0> (+1) ⬆️
src/Cache/CacheRegistry.php 95.83% <0%> (-4.17%) 11% <0%> (ø)
src/Cache/CacheEngine.php 91.3% <0%> (-2.18%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf426d...c68a773. Read the comment docs.

@markstory markstory merged commit 758e12b into cakephp:master Dec 4, 2017

5 checks passed

codecov/patch 100% of diff hit (target 93.38%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +6.61% compared to 3bf426d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@chinpei215 chinpei215 deleted the chinpei215:fix-callable-strings branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment