New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect tag for EntityInterface::getSource() #11607

Merged
merged 1 commit into from Jan 7, 2018

Conversation

Projects
None yet
3 participants
@o0h
Contributor

o0h commented Jan 6, 2018

Fix mismatch between EntityInterface and implements in EntityTrait.

With phan, static analyzer reports error.

Inflector::singularize($entity->getSource());

then

PhanTypeMismatchArgument Argument 1 (word) is array but \Cake\Utility\Inflector::singularize() takes string defined at vendor/cakephp/cakephp/src/Utility/Inflector.php:546
@codecov-io

This comment has been minimized.

codecov-io commented Jan 6, 2018

Codecov Report

Merging #11607 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11607   +/-   ##
=========================================
  Coverage     93.37%   93.37%           
  Complexity    13013    13013           
=========================================
  Files           436      436           
  Lines         32828    32828           
=========================================
  Hits          30652    30652           
  Misses         2176     2176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28400cb...e54c48b. Read the comment docs.

@markstory markstory added this to the 3.5.10 milestone Jan 7, 2018

@markstory markstory merged commit 9a53474 into cakephp:master Jan 7, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 28400cb...e54c48b
Details
codecov/project 93.37% remains the same compared to 28400cb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@markstory

This comment has been minimized.

Member

markstory commented Jan 7, 2018

Thanks!

@o0h o0h deleted the o0h:fix-entity-interface-annotation branch Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment