Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CONTRIBUTING.md #1173

Merged
merged 1 commit into from Mar 22, 2013
Merged

add CONTRIBUTING.md #1173

merged 1 commit into from Mar 22, 2013

Conversation

ceeram
Copy link
Contributor

@ceeram ceeram commented Mar 12, 2013

No description provided.

@lorenzo
Copy link
Member

lorenzo commented Mar 12, 2013

All caps makes me feel uncomfortable

@ceeram
Copy link
Contributor Author

ceeram commented Mar 12, 2013

for the filename? thats what github says it should be named https://github.com/blog/1184-contributing-guidelines

## Which branch to base the work

* Bugfix branches will be based on master.
* Backwards compatible few features will be based on next minor release branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few=new ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right ill fix that

@markstory
Copy link
Member

README files are also often in all caps.

* Write patches for open bug/feature tickets, preferably with testcases included
* Contribute to the [documentation](https://github.com/cakephp/docs)

There are a few guidelines that we need contributors to follow so that we can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the trailing can here.

@ceeram
Copy link
Contributor Author

ceeram commented Mar 12, 2013

I changed accordingly to your comments. You think its nice to have this file available for people opening a pull request?

@markstory
Copy link
Member

I do, more documentation and more help with contributing is generally a good thing. I think we should give it a shot. If people really hate it we can always take it out 😄

@lorenzo
Copy link
Member

lorenzo commented Mar 12, 2013

I think it is a good idea, sorry for my initial rant :P

On Tue, Mar 12, 2013 at 3:08 PM, Mark Story notifications@github.comwrote:

I do, more documentation and more help with contributing is generally a
good thing. I think we should give it a shot. If people really hate it we
can always take it out [image: 😄]


Reply to this email directly or view it on GitHubhttps://github.com//pull/1173#issuecomment-14776915
.

markstory added a commit that referenced this pull request Mar 22, 2013
@markstory markstory merged commit 61cc9b3 into cakephp:master Mar 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants