New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CONTRIBUTING.md #1173
add CONTRIBUTING.md #1173
Conversation
All caps makes me feel uncomfortable |
for the filename? thats what github says it should be named https://github.com/blog/1184-contributing-guidelines |
## Which branch to base the work | ||
|
||
* Bugfix branches will be based on master. | ||
* Backwards compatible few features will be based on next minor release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few=new ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right ill fix that
README files are also often in all caps. |
* Write patches for open bug/feature tickets, preferably with testcases included | ||
* Contribute to the [documentation](https://github.com/cakephp/docs) | ||
|
||
There are a few guidelines that we need contributors to follow so that we can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need the trailing can here.
I changed accordingly to your comments. You think its nice to have this file available for people opening a pull request? |
I do, more documentation and more help with contributing is generally a good thing. I think we should give it a shot. If people really hate it we can always take it out 😄 |
I think it is a good idea, sorry for my initial rant :P On Tue, Mar 12, 2013 at 3:08 PM, Mark Story notifications@github.comwrote:
|
No description provided.