New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php7.3 to build matrix in allow failure mode. #12488

Merged
merged 15 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@markstory
Member

markstory commented Aug 21, 2018

Lets see what happens 馃

@markstory markstory added this to the 3.6.11 milestone Aug 21, 2018

.travis.yml Outdated
@@ -5,6 +5,7 @@ php:
- 5.6
- 7.1
- 7.2
- 7.3

This comment has been minimized.

@ADmad

ADmad Aug 21, 2018

Member

There's no 7.3 available on travis. Probably need to use nightly instead.

This comment has been minimized.

@ADmad

ADmad Aug 21, 2018

Member

Actually seems we need to wait for travis-ci/travis-ci#9717 to be resolved.

This comment has been minimized.

@markstory

markstory Aug 21, 2018

Member

Well I guess we'll have to wait then.

This comment has been minimized.

@ravage84

ravage84 Sep 11, 2018

Member

Regardless of when the related issue is resolved, what keeps us from adding nightly (with allow_failures)?

This comment has been minimized.

@ADmad

ADmad Sep 11, 2018

Member

Nothing keeping us but what would testing against nightly aka 7.4-dev so early achieve, except contributing to global warming? :)

@codecov

This comment has been minimized.

codecov bot commented Aug 21, 2018

Codecov Report

鉂楋笍 No coverage uploaded for pull request base (master@3ddec46). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #12488   +/-   ##
=========================================
  Coverage          ?   91.97%           
  Complexity        ?    13691           
=========================================
  Files             ?      467           
  Lines             ?    35212           
  Branches          ?        0           
=========================================
  Hits              ?    32385           
  Misses            ?     2827           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3ddec46...ef0f25b. Read the comment docs.

@markstory markstory modified the milestones: 3.6.11, 3.6.12 Sep 3, 2018

@markstory markstory referenced this pull request Sep 5, 2018

Closed

Undefined variable: eTagMatches #12536

1 of 3 tasks complete

@ADmad ADmad closed this Sep 10, 2018

@ADmad ADmad reopened this Sep 10, 2018

@ADmad ADmad force-pushed the 73-compat branch from 0002419 to 032ffa8 Sep 28, 2018

@ADmad ADmad force-pushed the 73-compat branch from 032ffa8 to af5bb36 Sep 28, 2018

ADmad added some commits Sep 28, 2018

Turn off mysql's ONLY_FULL_GROUP_BY mode.
It's causing tests in QueryTest::testSelectDistinctON() to fail.
@ADmad

This comment has been minimized.

Member

ADmad commented Sep 28, 2018

Builds now running on PHP 7.3.0RC1. Had to tweak few things to fix failures on other PHP versions too since xenial distro needs to be used for PHP 7.3 installation.

Hopefully someone can use hacktoberfest to fix the failures on PHP 7.3

Took care of it myself.

@ADmad ADmad force-pushed the 73-compat branch from 8c920cb to e74169d Sep 29, 2018

ADmad added some commits Sep 29, 2018

Use CACHE instead of TMP.
Using tmp folder causes random write errors.
Dont install memcached for PHP 5.6 too.
Tests seem to fail for no reason.

@markstory markstory merged commit 9110e6c into master Oct 2, 2018

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory deleted the 73-compat branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment