Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc blocks. #12588

Merged
merged 3 commits into from Sep 26, 2018
Merged

Fix doc blocks. #12588

merged 3 commits into from Sep 26, 2018

Conversation

dereuromark
Copy link
Member

Inspired by #12587

Not being able to properly init the properties, makes also the expected result of isAutoLayoutEnabled() rather problematic.

@dereuromark dereuromark added this to the 3.6.12 milestone Sep 23, 2018
@dereuromark dereuromark mentioned this pull request Sep 23, 2018
@markstory
Copy link
Member

Test failures seem relevant.

@dereuromark
Copy link
Member Author

dereuromark commented Sep 24, 2018

Is it ok to change the test to the expected and documented type?
Never mind, this cleanup has to be done in 3.next or 4.0

@dereuromark dereuromark changed the title Fix doc blocks and isAutoLayoutEnabled() method. Fix doc blocks. Sep 24, 2018
@markstory markstory self-assigned this Sep 24, 2018
@markstory markstory merged commit b9862ed into master Sep 26, 2018
@markstory markstory deleted the master-docblocks branch September 26, 2018 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants