Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix some PHP 7.3 errors #12718
Looks pretty good to me. The multi byte class tests are a relic of how old 2.x is. Back when 2.x was started the mbstring extension was not commonly available. From what I remember the tests should be at least partially covering our code and not the just the php extension.