Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.7 cell - exception #12783

Merged
merged 1 commit into from Dec 9, 2018
Merged

3.7 cell - exception #12783

merged 1 commit into from Dec 9, 2018

Conversation

@saeideng
Copy link
Member

saeideng commented Dec 5, 2018

before this ( cake 3.6) we had this line to set correct file name into $template var

$template = $builder->getTemplate() ?: $this->template;

but now ( cake 3.7 ) it changed( removed)
this PR can help us to revert functionality

cake 3.6 : Could not render cell - Cell view file "test" is missing.
cake 3.7 : Could not render cell - Cell view file "" is missing.

@saeideng saeideng added the view label Dec 5, 2018
@saeideng saeideng added this to the 3.7.0 milestone Dec 5, 2018
src/View/Cell.php Outdated Show resolved Hide resolved
Refs: #12783
@saeideng saeideng force-pushed the 3.next-fix-exception-cell branch from 1be8c1c to 8c8ed0f Dec 8, 2018
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #12783 into 3.next will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             3.next   #12783      +/-   ##
============================================
- Coverage     90.03%   90.03%   -0.01%     
+ Complexity    14031    14018      -13     
============================================
  Files           522      522              
  Lines         36104    36076      -28     
============================================
- Hits          32508    32481      -27     
+ Misses         3596     3595       -1
Impacted Files Coverage Δ Complexity Δ
src/View/Cell.php 88.11% <100%> (ø) 37 <0> (ø) ⬇️
src/View/Form/FormContext.php 93.33% <0%> (-0.79%) 25% <0%> (-4%)
src/View/Form/NullContext.php 91.66% <0%> (-0.65%) 12% <0%> (-1%)
src/View/Form/EntityContext.php 98.14% <0%> (-0.09%) 91% <0%> (-4%)
src/View/Helper/FormHelper.php 94.19% <0%> (-0.03%) 382% <0%> (-2%)
src/View/Form/ArrayContext.php 94.66% <0%> (+0.99%) 38% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e9b48...8c8ed0f. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #12783 into 3.next will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             3.next   #12783      +/-   ##
============================================
- Coverage     90.03%   90.03%   -0.01%     
+ Complexity    14031    14018      -13     
============================================
  Files           522      522              
  Lines         36104    36076      -28     
============================================
- Hits          32508    32481      -27     
+ Misses         3596     3595       -1
Impacted Files Coverage Δ Complexity Δ
src/View/Cell.php 88.11% <100%> (ø) 37 <0> (ø) ⬇️
src/View/Form/FormContext.php 93.33% <0%> (-0.79%) 25% <0%> (-4%)
src/View/Form/NullContext.php 91.66% <0%> (-0.65%) 12% <0%> (-1%)
src/View/Form/EntityContext.php 98.14% <0%> (-0.09%) 91% <0%> (-4%)
src/View/Helper/FormHelper.php 94.19% <0%> (-0.03%) 382% <0%> (-2%)
src/View/Form/ArrayContext.php 94.66% <0%> (+0.99%) 38% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e9b48...8c8ed0f. Read the comment docs.

@markstory markstory modified the milestones: 3.7.0, 3.7.1 Dec 9, 2018
@markstory markstory changed the base branch from 3.next to master Dec 9, 2018
@markstory markstory merged commit 7a25480 into master Dec 9, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found
Details
@markstory markstory deleted the 3.next-fix-exception-cell branch Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.