Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow incorrect decimal / float formatting #12819

Merged
merged 4 commits into from Dec 14, 2018
Merged

Conversation

@segy
Copy link
Contributor

segy commented Dec 14, 2018

Fixes #12800

@dereuromark dereuromark added the defect label Dec 14, 2018
@dereuromark dereuromark added this to the 3.7.1 milestone Dec 14, 2018
src/Database/Type/DecimalType.php Outdated Show resolved Hide resolved
src/Database/Type/DecimalType.php Outdated Show resolved Hide resolved
src/Database/Type/DecimalType.php Outdated Show resolved Hide resolved
@ADmad

This comment has been minimized.

Copy link
Member

ADmad commented Dec 14, 2018

Tests failing.

@segy

This comment has been minimized.

Copy link
Contributor Author

segy commented Dec 14, 2018

I wasn't checking the type. Fixed

@ADmad

This comment has been minimized.

Copy link
Member

ADmad commented Dec 14, 2018

Nope, the code now allows non scalar values through and tests still fail. We'll save time if you run the tests locally 🙂.

@ADmad
ADmad approved these changes Dec 14, 2018
@markstory markstory merged commit d16504d into cakephp:master Dec 14, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.