Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotitations for integration trait setup/teardown #12822

Merged
merged 1 commit into from Dec 17, 2018
Merged

Conversation

@markstory
Copy link
Member

markstory commented Dec 16, 2018

Using setup/teardown as the method names means that implementing classes lose the setup/teardown logic defined in the trait when they redeclare those methods. By using different method names and annotations phpunit will run the implementing class's setup and ours.

Targeting this to master as we recommend people use the trait in our docs and bake now generates tests using the trait.

Refs #9794

Using setup/teardown as the method names means that implementing classes
lose the setup/teardown logic defined in the trait when they redeclare
those methods. By using different method names and annotations phpunit
will run the implementing class's setup and ours.
@markstory markstory added this to the 3.7.1 milestone Dec 16, 2018
@markstory markstory added the testing label Dec 16, 2018
@markstory markstory requested a review from jeremyharris Dec 16, 2018
@jeremyharris

This comment has been minimized.

Copy link
Member

jeremyharris commented Dec 16, 2018

Thanks for this, it was a complete oversight on my part.

@markstory markstory merged commit e2a6ad9 into master Dec 17, 2018
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found
Details
@markstory markstory deleted the issue-9794 branch Dec 17, 2018
@jeremyharris jeremyharris mentioned this pull request Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.