Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notice error on missing argument #12825

Merged
merged 1 commit into from Dec 17, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -117,7 +117,7 @@ public function hasArgument($name)
public function getArgument($name)
{
$offset = array_search($name, $this->argNames, true);
if ($offset === false) {
if ($offset === false || !isset($this->args[$offset])) {
return null;
}

@@ -96,6 +96,20 @@ public function testGetArgument()
$this->assertNull($args->getArgument('hair'));
}

/**
* get arguments missing value
*
* @return void
*/
public function testGetArgumentMissing()
{
$values = [];
$names = ['size', 'color'];
$args = new Arguments($values, [], $names);
$this->assertNull($args->getArgument('size'));
$this->assertNull($args->getArgument('color'));
}

/**
* test getOptions()
*
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.