Make PSR7 uploaded files accessible in integration tests #12833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12833 +/- ##
============================================
+ Coverage 90.42% 90.42% +<.01%
Complexity 14043 14043
============================================
Files 522 522
Lines 36121 36122 +1
============================================
+ Hits 32663 32664 +1
Misses 3458 3458
Continue to review full report at Codecov.
|
markstory
reviewed
Dec 21, 2018
| ['file' => 2010] | ||
| ], | ||
| ], | ||
| 'upload' => new UploadedFile(__FILE__, 42, 0) |
There was a problem hiding this comment.
This seems like something that should be possible. Is making this work complicated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes it possible to test controller actions that expect uploads are accessible from
getUploadedFiles().Unfortunately files passed as POST data body are not present in
getUploadedFiles()and to test those properly$_FILEShad to be injected with files directly.