Minor comment and path changes. #132

Merged
merged 1 commit into from Jul 2, 2011

Conversation

Projects
None yet
3 participants
@thatcode
Contributor

thatcode commented Jun 25, 2011

These are really minor, but I spotted them in passing and thought I'd deal with them.

The home.ctp line has recently been changed to that. Most web-visible lines have the APP prefix, so IMO this one should as well.

@ADmad

This comment has been minimized.

Show comment Hide comment
@ADmad

ADmad Jun 25, 2011

Member

Would be better if you lowercase APP to app

Member

ADmad commented Jun 25, 2011

Would be better if you lowercase APP to app

@thatcode

This comment has been minimized.

Show comment Hide comment
@thatcode

thatcode Jun 25, 2011

Contributor

I disagree. Web visible code paths have APP in capitals.

e.g (from the pages I've changed)
lib/Cake/Console/Templates/default/views/home.ctp Lines 28,32,93
lib/Cake/View/Pages/home.ctp Lines 53,57,115->117

The change to lib/Cake/console/Command/ConsoleShell.php is in a code comment, thus why it's lowercase and the others are not.

If you think they should all be lowercase, then maybe. But that would be a far larger change. However, APP is, IMO, better, as it means 'wherever your app is', not 'the app directory in your Cake Root' which may (if you've separated the 2, as I have) be different.

Contributor

thatcode commented Jun 25, 2011

I disagree. Web visible code paths have APP in capitals.

e.g (from the pages I've changed)
lib/Cake/Console/Templates/default/views/home.ctp Lines 28,32,93
lib/Cake/View/Pages/home.ctp Lines 53,57,115->117

The change to lib/Cake/console/Command/ConsoleShell.php is in a code comment, thus why it's lowercase and the others are not.

If you think they should all be lowercase, then maybe. But that would be a far larger change. However, APP is, IMO, better, as it means 'wherever your app is', not 'the app directory in your Cake Root' which may (if you've separated the 2, as I have) be different.

markstory added a commit that referenced this pull request Jul 2, 2011

Merge pull request #132 from thatcode/2.0
Minor comment and path changes.

@markstory markstory merged commit 2725718 into cakephp:2.0 Jul 2, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment