Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ref: #13392] Hash::sort with const dir #13397

Merged
merged 2 commits into from Jul 7, 2019

Conversation

@o0h
Copy link
Contributor

commented Jul 5, 2019

Described in #13392

To improve Hash::sort(), make it correspond to $dir with \SORT_ASC(or \SORT_DESC).
Please check testSortWithDirectionConst test case, it shows you "Hash::sort() with 'desc'" equals "Hash::sort() with '\SORT_DESC'" now.

src/Utility/Hash.php Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codecov Report

Merging #13397 into 3.next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             3.next   #13397   +/-   ##
=========================================
  Coverage     90.95%   90.95%           
- Complexity    13992    13994    +2     
=========================================
  Files           523      523           
  Lines         36307    36307           
=========================================
  Hits          33023    33023           
  Misses         3284     3284
Impacted Files Coverage Δ Complexity Δ
src/Utility/Hash.php 97.7% <100%> (ø) 249 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4267344...7e61e92. Read the comment docs.

@markstory markstory merged commit b459101 into cakephp:3.next Jul 7, 2019

6 checks passed

Inspection Summary
Details
codecov/patch 100% of diff hit (target 90.95%)
Details
codecov/project 90.95% (+0%) compared to 4267344
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found
Details

@markstory markstory added this to the 3.9.0 milestone Jul 7, 2019

@markstory

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Thanks!

markstory added a commit to cakephp/docs that referenced this pull request Jul 7, 2019

@o0h o0h deleted the o0h:hash-sort-accepts-sort-direction-num branch Jul 7, 2019

saeideng added a commit that referenced this pull request Jul 9, 2019

markstory pushed a commit to cakephp/utility that referenced this pull request Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.