Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run testsuite on PHP 7.4. #13433

Merged
merged 4 commits into from Jul 25, 2019

Conversation

@ADmad
Copy link
Member

commented Jul 23, 2019

Who wants to track down segfaults? 馃槂

@ADmad ADmad added this to the 3.8.2 milestone Jul 23, 2019

@markstory

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Booooo segfaults are very tedious to track down.

@codecov

This comment has been minimized.

Copy link

commented Jul 23, 2019

Codecov Report

Merging #13433 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13433      +/-   ##
============================================
+ Coverage     90.94%   90.95%   +<.01%     
- Complexity    14004    14006       +2     
============================================
  Files           523      523              
  Lines         36333    36340       +7     
============================================
+ Hits          33043    33052       +9     
+ Misses         3290     3288       -2
Impacted Files Coverage 螖 Complexity 螖
src/View/Helper/FormHelper.php 95.25% <100%> (酶) 384 <0> (酶) 猬囷笍
src/Console/ConsoleOptionParser.php 94.06% <100%> (酶) 129 <0> (酶) 猬囷笍
src/Filesystem/Folder.php 91.54% <100%> (酶) 168 <0> (酶) 猬囷笍
src/TestSuite/TestCase.php 92.22% <100%> (酶) 86 <0> (酶) 猬囷笍
src/Utility/Hash.php 97.73% <100%> (+0.03%) 249 <0> (+2) 猬嗭笍
src/I18n/RelativeTimeFormatter.php 94.52% <0%> (-0.5%) 74% <0%> (酶)
src/Cache/Engine/FileEngine.php 90.3% <0%> (+1.02%) 76% <0%> (酶) 猬囷笍
src/Cache/CacheRegistry.php 100% <0%> (+4.16%) 11% <0%> (酶) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8005880...a7e6ca3. Read the comment docs.

ADmad added some commits Jul 23, 2019

Avoid array_key_exists() check on objects.
PHP 7.4 throws deprecation error for such usage.

@ADmad ADmad force-pushed the travis-php7.4 branch from b21299b to a7e6ca3 Jul 24, 2019

@ADmad

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Can we merge this? The changes are good for all currently supported PHP versions and 7.4.

We can try figuring out the segfaults on PHP 7.4 later. Or maybe it will resolve itself with never builds of 7.4 馃檪.

@dereuromark dereuromark merged commit 53718eb into master Jul 25, 2019

7 checks passed

Inspection Summary
Details
codecov/patch 100% of diff hit (target 90.94%)
Details
codecov/project 90.95% (+<.01%) compared to 8005880
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found
Details

@dereuromark dereuromark deleted the travis-php7.4 branch Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.