Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @throws tag to Table::findOrCreate #13449

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@o0h
Copy link
Contributor

commented Jul 30, 2019

ref: d840670 / #12914

Since 3.8.0, Table::findOrCreate() throws exception when the data was not saved.
To follow this change, update phpdoc.

@codecov

This comment has been minimized.

Copy link

commented Jul 30, 2019

Codecov Report

Merging #13449 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13449      +/-   ##
============================================
+ Coverage     90.94%   90.95%   +<.01%     
  Complexity    14004    14004              
============================================
  Files           523      523              
  Lines         36336    36336              
============================================
+ Hits          33045    33048       +3     
+ Misses         3291     3288       -3
Impacted Files Coverage Δ Complexity Δ
src/ORM/Table.php 94.58% <ø> (ø) 293 <0> (ø) ⬇️
src/Cache/Engine/FileEngine.php 90.3% <0%> (+1.02%) 76% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4.16%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a77c83...f0e2e64. Read the comment docs.

@markstory markstory added this to the 3.8.2 milestone Jul 31, 2019

@markstory markstory merged commit 30873b1 into cakephp:master Jul 31, 2019

6 checks passed

Inspection Summary
Details
codecov/patch Coverage not affected when comparing 3a77c83...f0e2e64
Details
codecov/project 90.95% (+<.01%) compared to 3a77c83
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.