AuthComponent: Allow suppressing authError message #1354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why should the merge button not be used? |
|
You should update the authError doc block to mention that it can be set to false to disable error messages. Other than that this seems reasonable. |
|
Okay. I will update docs and docblocks before merging. re: merge button: just want to make the history linear when it only a small change |
When unauthenticated users accesses protected areas, they are greeted with the default 'You are not allowed to access that location' which is not desired in some cases. This patch allows applications to suppress this message by setting AuthComponent::authError to false bypassing the call to SessionComponent::setFlash() altogether. Refs: croogo/croogo#175 (comment)
|
I'm too lazy to do a local merge though 😄 |
|
Landed in 0d486bd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unauthenticated users accesses protected areas, they are greeted
with the default
You are not allowed to access that locationwhich isnot desired in some cases.
This patch allows applications to suppress this message by setting
AuthComponent::authErrortofalsebypassing the call toSessionComponent::setFlash()altogether.Refs: croogo/croogo#175 (comment)
Note: Please fast-forward and don't use the merge button :)