Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate calling TableLocator::clear() #14005

Merged

Conversation

@o0h
Copy link
Contributor

o0h commented Dec 11, 2019

In Cake\TestSuite\TestCase::tearDown(), $this->getTableLocator()->clear() is called.
So each subclasses' tearDown() don't have to call it.

This PR is to

  • Remove duplication calling TableLocator::clear()
  • Remove tearDown() implemented only to call TableLocator::clear()
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #14005 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #14005      +/-   ##
============================================
- Coverage     91.01%      91%   -0.01%     
  Complexity    14058    14058              
============================================
  Files           524      524              
  Lines         36214    36214              
============================================
- Hits          32960    32957       -3     
- Misses         3254     3257       +3
Impacted Files Coverage Δ Complexity Δ
src/Cache/CacheRegistry.php 95.83% <0%> (-4.17%) 11% <0%> (ø)
src/Cache/Engine/FileEngine.php 89.11% <0%> (-1.04%) 76% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b67f1...e8e55a9. Read the comment docs.

@ADmad ADmad added this to the 3.8.8 milestone Dec 11, 2019
@ADmad ADmad added the cleanup label Dec 11, 2019
@ADmad ADmad merged commit 4ae2a55 into cakephp:master Dec 11, 2019
5 of 6 checks passed
5 of 6 checks passed
codecov/project 91% (-0.01%) compared to d4b67f1
Details
Inspection Summary
Details
codecov/patch Coverage not affected when comparing d4b67f1...e8e55a9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found
Details
@o0h o0h deleted the o0h:remove-unnecessary-calling-tablelocator-clear branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.