Skip to content
This repository

I change one line in Controller.php #164

Closed
wants to merge 3 commits into from

1 participant

Andy Dawson
Deleted user
ghost commented

The content you are editing has changed. Reload the page and try again.

I have changed from

public function __construct($request = null, $response = null) {
if ($this->name === null) {

to

public function __construct($request = null, $response = null) {
if ($this->name == null) {

Sending Request…

Attach images by dragging & dropping or selecting them. Octocat-spinner-32 Uploading your images… Unfortunately, we don't support that file type. Try again with a PNG, GIF, or JPG. Yowza, that's a big file. Try again with an image file smaller than 10MB. This browser doesn't support image attachments. We recommend updating to the latest Internet Explorer, Google Chrome, or Firefox. Something went really wrong, and we can't process that image. Try again.

Andy Dawson
Collaborator
AD7six commented

we can read the diff to see what you've changed - the discussion is for why.

== is slower than ===, there is no benefit to this change.

Andy Dawson AD7six closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 3 unique commits by 1 author.

Jul 30, 2011
Edited README via GitHub 56c5234
Edited README via GitHub 99af2af
Edited cake/libs/controller/controller.php via GitHub 7b85f15
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. 2  cake/libs/controller/controller.php
2  cake/libs/controller/controller.php
@@ -360,7 +360,7 @@ class Controller extends Object {
360 360
  *
361 361
  */
362 362
 	function __construct() {
363  
-		if ($this->name === null) {
  363
+		if ($this->name == null) {
364 364
 			$r = null;
365 365
 			if (!preg_match('/(.*)Controller/i', get_class($this), $r)) {
366 366
 				__("Controller::__construct() : Can not get or parse my own class name, exiting.");
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.