Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility shim for errorLogger #16600

Merged
merged 2 commits into from Jul 5, 2022
Merged

Conversation

markstory
Copy link
Member

@markstory markstory commented Jul 4, 2022

Users with custom error logging will be using the errorLogger key. In order for them to complete their upgrade to ErrorTrap they need to use the logger key instead.

Users with custom error logging will be using the `errorLogger` key. In
order for them to complete their upgrade to `ErrorTrap` they need to use
the `logger` key instead.
if ($oldConfig !== null) {
deprecationWarning('The `errorLogger` configuration key is deprecated. Use `logger` instead.');
$this->setConfig('logger', $oldConfig);
}
Copy link
Member

@othercorey othercorey Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this clear the old config so the warning isn't triggered every time?

Copy link
Member Author

@markstory markstory Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@othercorey othercorey merged commit 88c8d94 into 4.x Jul 5, 2022
10 of 13 checks passed
@othercorey othercorey deleted the errorlogger-deprecation branch Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants