Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused properties. #16646

Merged
merged 1 commit into from Jul 21, 2022
Merged

Deprecate unused properties. #16646

merged 1 commit into from Jul 21, 2022

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Jul 21, 2022

No description provided.

@ADmad ADmad added this to the 4.4.3 milestone Jul 21, 2022
@ADmad ADmad marked this pull request as ready for review Jul 21, 2022
@othercorey
Copy link
Member

othercorey commented Jul 21, 2022

I wonder if this was meant to be used by the compiler at some point.

@ADmad
Copy link
Member Author

ADmad commented Jul 21, 2022

Seems so, QueryCompiler has the same properties.

@othercorey
Copy link
Member

othercorey commented Jul 21, 2022

Looks ok to me. I don't think we need to validate them in Query.

@markstory markstory merged commit 593064b into 4.x Jul 21, 2022
12 of 13 checks passed
@markstory markstory deleted the 4.x-query branch Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants