Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix build for MySQL 8.0.30 #16670

Merged
merged 1 commit into from Aug 5, 2022
Merged

Attempt to fix build for MySQL 8.0.30 #16670

merged 1 commit into from Aug 5, 2022

Conversation

markstory
Copy link
Member

@markstory markstory commented Aug 4, 2022

See if this lets us get a green build again.

@markstory markstory added this to the 4.4.4 milestone Aug 4, 2022
@markstory markstory linked an issue Aug 4, 2022 that may be closed by this pull request
@othercorey
Copy link
Member

othercorey commented Aug 4, 2022

In the last 2 days, there was a new implementation of mb_strimwidth introduced into php 8.2. That might be the cause of the failure.

php/php-src@7299096

@othercorey
Copy link
Member

othercorey commented Aug 4, 2022

the fix looks good. let's revert the string compare changes and let it fail until php 8.2 is fixed.

will re-check with mysql 5.7 after this is merged #16657

@markstory
Copy link
Member Author

markstory commented Aug 5, 2022

Nice only the segfault from 8.2 left now.

@markstory markstory merged commit 4210057 into 4.x Aug 5, 2022
21 of 24 checks passed
@markstory markstory deleted the fix-build branch Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants