Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add theme path /app/plugins/<plugin>/views/themed/<theme>/ #174

Closed
wants to merge 1 commit into from

3 participants

@TooMuchCaffeine

Just like plugin assets have a webroot under plugin root for the sake of packaging
themesPaths should also include this path /app/plugins/pizza/views/themed/thin_crust/

@johannesnagl

+1 - we had the same issue this week.

@markstory
Owner

Theme's shouldn't go in plugins. Themes are 'view only' plugins. Having theme's in plugins makes little sense given the idea that themes are a way of making re-usable view content. This has come up before and not been accepted for the same reason. If anything it indicates to me that themes really have no purpose, and that we should allow 'theming' to occur using plugins instead of having two similar but confusingly different ways of creating re-usable bits.

@markstory markstory closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 12, 2011
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +3 −1 cake/libs/view/theme.php
View
4 cake/libs/view/theme.php
@@ -65,7 +65,9 @@ function _paths($plugin = null, $cached = true) {
$themePaths[] = $paths[$i] . 'themed'. DS . $this->theme . DS . 'plugins' . DS . $plugin . DS;
}
$themePaths[] = $paths[$i] . 'themed'. DS . $this->theme . DS;
- }
+ } elseif ($plugin && strpos($paths[$i], DS . 'plugins' . DS . $plugin . DS . 'views') !== false) {
+ $themePaths[] = $paths[$i] . 'themed' . DS . $this->theme . DS;
+ }
}
$paths = array_merge($themePaths, $paths);
}
Something went wrong with that request. Please try again.