Makes autoLinkUrls not attempt to change urls for iframes, embeds, images...etc #207

Closed
wants to merge 3,602 commits into
from

Conversation

Projects
None yet
Contributor

daVinciWanaB commented Sep 21, 2011

Doesn't seem any reason a user would ever want to add "<a href=..." to a link within "src=''"

jrbasso and others added some commits Jul 30, 2011

@jrbasso jrbasso Fixed some API doc in controllers and errors. 3723f7d
@jrbasso jrbasso Fixed some API doc in routing and cache. e74d835
@jrbasso jrbasso Fixed some API doc in model. 39b4032
@jrbasso jrbasso Changed the signature of methods to avoid strict messages. e4a1816
@jrbasso jrbasso Changed the visibility to protected. db80fe2
@jrbasso jrbasso Removed the @access and @static. 9bc3e56
@ADmad ADmad Enhancing validation messages to have placeholders. Closes #1855 b15c77e
@lorenzo lorenzo Making ControllerTestCase abstract, that way PHP won't complain about…
… empty test cases, closes #1868
eaa0163
@ADmad ADmad Fixed TreeBehavior::childCount(). Closes #1833 9577fb0
@jrbasso jrbasso Included @throws in API that was missing. fedadc0
@jrbasso jrbasso Included @var in API that was missing. 2a50a1e
@jrbasso jrbasso Fixed type to parameters that is defined in the code. ebb70c4
@jrbasso jrbasso Updated some file headers to include correct license and copyright. 7604763
@jrbasso jrbasso Using @property to autocomplete components and helpers in some IDEs. …
…Also added @property to bake of controller and model. Fixes #103.
d84531d
@jrbasso jrbasso Changed method API description. 4df585e
@jrbasso jrbasso Adjusted some types in @param, @return and @var. 895c10a
@markstory markstory Merge pull request #157 from ProLoser/patch-2
Added `'integer' => 'number'` for HTML5
4da671c
@ceeram ceeram moving test icons one dir up, and remove subdir img in img dbdc0a1
@ceeram ceeram Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 e083b21
@markstory @markstory markstory Re-adding support for PHP's include_path.
Moving constants that are made of other constants into bootstrap.php
721c438
@markstory @markstory markstory Making skel files generate hard coded paths, when CakePHP
is not on the include_path, and exclude hard coded paths when it is.
20e9015
@markstory @markstory markstory Removing APP_PATH it is always the same as APP.
Fixing a typo in index.php.
6e2870c
@markstory @markstory markstory Doing some refactoring in the project task.
Adding tests for constants staying commented out when CakePHP is on the include_path.
cdcabc7
@markstory @markstory markstory Changing assertPattern to assertRegExp. b362afe
@markstory @markstory markstory Adding comments about CAKE_CORE_INCLUDE_PATH.
Removing ini_set() blocks that don't need to exist.
b45e8eb
@markstory markstory Updating output of project task to better reflect what
happened.
c1b0eb8
@markstory markstory Making long options & arguments replaced with short forms.
Fixes #1882
5f84b48
@markstory markstory Fixing incorrectly inflected shell names in help. fb756c5
@markstory markstory Fixing bad include on text reporter.
Fixing bad includes and updating usage in text coverage reports.
10c78c5
@markstory markstory Adding an exception when a short option is longer than one
character. Having long short options breaks parsing, and
doesn't make sense with how short options are used.
b739127
@markstory markstory Fixing issues where option values started with '-'. 5d3c470
@markstory markstory Fixing issues output xml help. 2f079b3
@markstory markstory Fixing notice errors caused by undefined property. be262f3
@markstory markstory Cleanup of minor issues found with phpmd. e4a7c8f
@markstory markstory Fixing parameter name in RssHelper docs.
Fixes #1888
5330096
@markstory markstory Updating doc blocks in Debugger and CakeLog. 4ab9ded
@markstory markstory Expanding docs on HtmlHelper. a268eea
@markstory markstory Fixing plugin option + locations subcommand. 95f3eb4
Maggion Emmanuel Adding `cake_dev` domain 7ab1805
@renan renan Merge pull request #168 from kamui545/patch-1
Adding `cake_dev` domain
eb7567d
Maggion Emmanuel Adding support for url input cb5f57f
@majna majna Fix for wrong 'cake_dev' i18n domain param. 48e6814
@renan renan Merge pull request #170 from majna/2.0-i18n-domain
Fixed wrong i18n domain param: 'cake_developer'
ed8daf8
Maggion Emmanuel Edited lib/Cake/View/Helper/FormHelper.php via GitHub 6cd89b0
Maggion Emmanuel Adding test case 2773450
@majna majna Added doc blocks for WincacheEngine. Fixed Memcache doc block. 826001a
@renan renan Merge pull request #171 from majna/2.0-cache-config
Added doc blocks for WincacheEngine. Fixed Memcache doc block.
9e2db27
@ADmad ADmad Merge pull request #169 from kamui545/patch-1
Adding support for url input
8d8d64a
@markstory markstory Fixing failing tests. e9382d0
@markstory markstory Fixing issue where postLink() would fail when used with SecurityCompo…
…nent.
2ce2d06
@markstory markstory Adding tests for FormHelper::postButton() and SecurityComponent. 6026aa4
@lorenzo lorenzo Re-adding primaryKey detection support to FormHelper, it was removed …
…mistakenly in last refactor
3d46172
@lorenzo lorenzo Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 9b6ea7d
@lorenzo lorenzo Adding ability to Set class to iterate on ArrayObjects, or any object…
… implementing ArrayAccess and Traversable
1726bad
@markstory markstory Fixing notice error when all csrf tokens are expired at once.
Fixes #1901
1df8de6
@markstory markstory Fixing issues with CSRF token failure and requestAction.
Fixes #1900
3014d3f
@markstory markstory Fixing issues with request stack not being used correctly
when there are requestAction requests being performed.
Adding Router::popRequest() to allow manipulation of request stack
so nested requestAction or serial requestAction calls work correctly.
Fixes #1906
fdacc9d
@ADmad ADmad Data returned by Model::save() not contains primary key too when new …
…record is created. Closes #1869
7983b41
@ADmad ADmad Fixing regression in Set::extract(). Refs #1895, #1816, #1692. b781762
@ADmad ADmad For paging links the 'class' attribute is now always applied to the w…
…rapping tag for consistency. Closes #1759
5d79299
@ADmad ADmad Making Model::find('count') behave nicely when 'group' key is specifi…
…ed in options. Closes #1677
ef4826e
Member

dereuromark commented on 7983b41 Aug 14, 2011

"Data returned by Model::save() not contains primary key too when new record is created. Closes #1869"
not should probably read now :)

Member

ADmad replied Aug 14, 2011

Right its a typo, "not" should be "now". I realized that after I had already pushed couple of other commits so couldn't really do anything about it. Maybe if you had sent a pull request too with required changes for your ticket this would have been avoided :)

Member

dereuromark replied Aug 14, 2011

Well, I guess I take full responsibility then.

markstory and others added some commits Aug 14, 2011

@markstory markstory Merge branch '1.3' into merger
Conflicts:
	cake/libs/controller/components/security.php
	cake/libs/view/pages/home.ctp
	cake/libs/view/view.php
	lib/Cake/Cache/Engine/FileEngine.php
	lib/Cake/Config/config.php
	lib/Cake/Model/Datasource/Database/Postgres.php
	lib/Cake/Test/Case/Utility/SanitizeTest.php
	lib/Cake/Test/Case/Utility/SetTest.php
	lib/Cake/Test/Case/View/Helper/CacheHelperTest.php
	lib/Cake/Test/Case/View/Helper/FormHelperTest.php
	lib/Cake/VERSION.txt
	lib/Cake/View/Helper/CacheHelper.php
d93c8cb
@markstory markstory Fixing failing cache tests. e29eb1c
@markstory markstory Fixing failing test. In 2.0, absolute paths are not altered. 182b13f
@jrbasso jrbasso Merge branch '2.0' into 2.0-api-doc
Conflicts:
	lib/Cake/Test/Case/View/Helper/CacheHelperTest.php
	lib/Cake/Utility/Debugger.php
620a65b
@jrbasso jrbasso Description to some attributes in Model. 725e512
@jrbasso jrbasso Updating some sentenses. 0fcf6f6
@jrbasso jrbasso More API description/examples to relations variables. 7581db2
@ADmad ADmad Optimizing various finds when deleting records and updating counter c…
…ache to avoid extra queries, unnecessary joins and callbacks triggering
2b342d9

Merging commits from 1.3 has this problem that we loose the visibility keyword for functions :(

Owner

markstory replied Aug 15, 2011

I'll go back and add them in. I totally missed that.

Member

jrbasso replied Aug 15, 2011

I can include in api script (https://gist.github.com/1113866) to check about the visibility word in all the whole methods.

Member

ADmad replied Aug 15, 2011

That would be nice. We should probably have a shell in the core itself for checking coding standards. That would also help promote best practices among the framework users. The shell could be setup as a pre-commit hook.

Owner

markstory commented on d93c8cb Aug 17, 2011

I fixed up the visibility issues in 54e1de9

ADmad and others added some commits Aug 17, 2011

@ADmad ADmad Implemented feature to allow multiple counter caches per associated m…
…odel.
c3884f4
@ceeram ceeram config() will apply configs from email.php if string is passed 803cd28
@ceeram ceeram CakeEmail constructor now accepts $config 138aae6
@markstory markstory Removing XmlHelper references in layouts.
Fixes #1916
0e21093
@jrbasso jrbasso Added visibility in some methods and attributes. 0575e92
@markstory markstory Fixing issues with HTML5 number inputs and float columns.
For float columns, the default step value is 'any'
Fixes #1907
46c07ad
@jrbasso jrbasso Fixing more documentations. 40654df
@ceeram ceeram Change casing of delivery method being passed to transport(), to ensu…
…re correct transport class will be loaded
acdfb48
@jrbasso jrbasso Fixed the Memcache::clear() to not flush all the server, just the var…
…iables associated with the prefix. Refs #1911
3dd86eb
@jrbasso jrbasso Changed methods and attributes from private to protected. f5a54d0
@jrbasso jrbasso Changed the visibility to methods that not affect others classes. 6183329
@jrbasso jrbasso Merge remote-tracking branch 'origin/2.0' into 2.0-api-doc
Conflicts:
	lib/Cake/Model/Model.php
	lib/Cake/View/Helper/CacheHelper.php
a1a049c
@markstory markstory Making ApcEngine::clear() only clear keys with a matching
prefix. Refs #1911
ef921fa
@markstory markstory Adding prefix based cache clearning to Wincache.
This matches APC and Memcache.
Fixes #1911
0091fac
@markstory markstory Fixing options[data] always writing its data into $_POST['data'].
It now just overwrites $_POST.
Fixes #1917
70f4737
@markstory markstory Fixing issues where ControllerTestCase couldn't properly hit plugin
controllers.
Fixing some formatting.
Fixes #1918
7276f33
@markstory markstory Adding Todo about moving Cookie setting to CakeResponse. 5888839
@jrbasso jrbasso Fixed some problems caused by the visibility changes. 689c7ff
@jrbasso jrbasso Changed mergeAssociation scrubQueryData to be protected. e939098
@jrbasso jrbasso Fixed documentation to methods that use func_get_args(). f7f3515
@jrbasso jrbasso Changed protected callbacks of scaffold to public in Controller. dbb87a0
@ADmad ADmad Fixing doc block related to session configuration. Closes #1927 34d3d6f
@markstory @markstory markstory Adding a constant for TIME_START as $_SERVER[REQUEST_TIME] is only
accurate to the second.  Profilers and timers need ms resolution
to be accurate.
8503ffd
@markstory @markstory markstory Adding doc block info for Debugger::output(). ea3b38e
@markstory @markstory markstory Extracting methods from nasty Debugger::output(). 35fc835
@markstory @markstory markstory Adding tests for Debugger::outputAs()
Adding exceptions for invalid state checking.
daf1251

markstory and others added some commits Sep 3, 2011

@markstory markstory Adding an exception for when a PDO interface is not installed. cc8d44f
@lorenzo lorenzo Removing $error property from DboSource, errors in queries will throw…
… exceptions now
36470f4
@markstory markstory Fixing errors and failing tests with SQLite.
Seems that MySQL is extremely permissive with NOT NULL fields.
SQLite is more strict it seems.
2ceea79
@lorenzo lorenzo Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 49b8b24
@markstory markstory Removing trigger_warning() that causes tests to fail in Sqlite, as
it does not assign lengths for integer columns.
4172eac
@lorenzo lorenzo Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 d24c408
@markstory markstory Fixing failing tests and issues with Sqlite. 2c21fc9
@lorenzo lorenzo Making postgres tests pass f0ef0aa
@lorenzo lorenzo Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 0ca8af2
@lorenzo lorenzo Adding missing expectedException annotations 7003ede
@lorenzo lorenzo Fixing a failing postgres test fcf5837
@lorenzo lorenzo Not checking length on databases that won't return it for floats d06d5f8
@markstory markstory Fixing a few more failing tests.
Adding some parent calls to tests, removing duplicated junk.
d597186
@lorenzo lorenzo Making DboSource tests more portable 61ff8d6
@lorenzo lorenzo Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 93d6cd4
@lorenzo lorenzo More postgres tests passing again 74ba030
@lorenzo lorenzo All tests passing on postgres 8897335
@lorenzo lorenzo Fixing Mysql test case after making the DboSource throw exceptions 149deba
@markstory markstory Fixing failing test. dbf801b
@markstory markstory Fixing the one failing Multibyte test. 8c8dc6c
@markstory markstory Fixing mistake in last commit. 8630f4c
@lorenzo lorenzo Skipping tests on Sqlite that involve creating a duplicate connection…
…/ It is not possible to open multiple connections to it
12c7380
@lorenzo lorenzo Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 843f7e3
@lorenzo lorenzo Adding a new exception renderer method to show useful error for faile…
…d queries
3d0af8b
@lorenzo lorenzo Oops, removing testing code 95c25a0
@markstory markstory Removing a failing test. I think the encoding of the file has changed…
… over time,

and I don't have a typeface with lowercase Georgian text.
2218923
@markstory markstory Removing more flaky tests. 684c154
@lorenzo lorenzo Releasing 2.0.0-RC1 b2fac1b
@kamui545 kamui545 Fixed typo d675b42
@markstory markstory Merge pull request #187 from kamui545/patch-2
Fixed typo
7adcfd6
@markstory markstory Deprecating the %page% style placeholders in PaginatorHelper.
Updating scaffold and bake templates to not use deprecated placeholders.
3d44489
@markstory markstory Updating documentation with missing option. a0d531c
@markstory markstory Attempting to fix build failure in Jenkins. 39c270f
@markstory markstory Register AppHelper for autoloading
Fixes issues where people with no core helpers loaded would hit fatal
errors.
Fixes #1973
9587892
Jelle Henkens Adding tests for HtmlHelper e6826fe
@markstory markstory Fix create() and onsubmit option.
Removing support for onSubmit variant.  Additional
choices are not necessary. Fixing onsubmit option
not correctly working.
Fixes #1977
6ab59a4
@markstory Jelle Henkens Added tests to test ajax settings 3c8c293
@markstory markstory Merge pull request #192 from jellehenkens/2.0-html-helper-tests
Added tests for the HtmlHelper for code that was not covered
8880e0c
@markstory markstory Add fix and test for CamelBack input names.
Refs #1974
fa8bdfd
@markstory markstory Moving declaration of $fieldset
Its used in base Helper methods, so that's where the property
should live as well.
d6b978c
@markstory markstory Fix issue with HABTM fields
habtm fields were not being correctly being detected.
1743eaa
@markstory markstory Adding App::uses() call to model baking.
Models should always include their parent classes to be safe.
Bake should reflect the best practice.
Refs #1971
7c08c96
@markstory markstory Add App::uses to baked controllers.
Controllers should load their dependencies.
Bake should help with the best practice.
Fixes #1971
3cb3424
@markstory Jelle Henkens Fixing test by splitting them up, testing the expected error ignored …
…the next asserts
aa45452
@markstory markstory Refactoring test.
Removing expectError() replacing it with PHPUnit annotation.
608e5ee
@markstory Jelle Henkens Adding missing test scenarios in the paginator helper 653163c
Jelle Henkens Adding missing test scenarios in the rss helper 38196bd
Jelle Henkens Improved error handling for writing the test file to disk 236200c
@ADmad ADmad Refactoring Model::invalidFields() a bit. 97a975c
@markstory markstory Merge pull request #198 from jellehenkens/2.0-rss-helper-tests
Added tests for the RssHelper for code that was not covered
0e9b3dd
@markstory markstory Updating doc blocks. 9b8c280
@markstory markstory Making test case class names match file names.
Refs #1985
d74f442
@markstory markstory Adding 'vendors' alias to App
- Vendor is the new directory name, and a legacy mapping should exist.
  This makes App::path() match App::import() and all other packages.
- Add an alias for plugins -> Plugin.  It also was missing the alias,
  that matches the new style package names.

Fixes #1972
59e3065
@markstory markstory Fixing failing test from previous commit. 8272705
Jelle Henkens Refactoring expectError() calls to PHPUnit annotations 7ba2f90
@markstory markstory Trying to fix occasional error during FixtureTaskTest. 4fda085
@markstory markstory Splitting AclTest into multiple test case files.
Fixes #1985
42dccac
@renan renan Adding `tests` method to Upgrade shell, fixing FooTestCase to FooTest.
Also making sure the preg_match matches the right class and not move the file to other directory rather than tests.
The method `tests` need to be run before `locations` to work properly.
cd6c370
@predominant predominant Fixed incorrect ife() conversion. Thanks SkieDr. d8468c1
@predominant predominant Fix comment for ife() Upgrade. Thanks SkieDr. 9d1e3cb
@ADmad ADmad For MySQL you can now specify the socket to use using `unix_socket` k…
…ey in the config array. Closes #1994
7c87e9a
@renan renan Fixed bug in CakeSchema where it determines the field position.
- Respective tests were added.
- Schema files will now have 'after' => 'previous_field' on it.
4378bb6
@markstory markstory Splitting apart the Scaffold and ScaffoldView tests.
Fixes #1985
09e7f1d
@markstory markstory Fix entity names for associated model date fields.
Fixes #1993
85b86cb
@markstory markstory Make full page caching + Themes work.
Dispatcher now uses ThemeView for rendering cache files.
This enables nocache blocks to reference theme elements.
Fixes #1858
0e5797d
@ADmad ADmad The 'default' config for Configure class is now auto created on first…
… use if not already created.
08026e5
@ADmad ADmad Fixing doc block 670fea6
@markstory markstory Merge branch '1.3' into merger
Conflicts:
	cake/basics.php
	cake/console/libs/tasks/extract.php
	cake/libs/view/helpers/js.php
	cake/tests/cases/console/libs/tasks/extract.test.php
	cake/tests/cases/libs/model/datasources/dbo/dbo_mysql.test.php
	cake/tests/cases/libs/model/datasources/dbo_source.test.php
	cake/tests/test_app/views/pages/extract.ctp
	lib/Cake/Cache/Engine/MemcacheEngine.php
	lib/Cake/Model/Behavior/ContainableBehavior.php
	lib/Cake/Model/Datasource/Database/Mysql.php
	lib/Cake/Model/Datasource/DboSource.php
	lib/Cake/Model/Model.php
	lib/Cake/Test/Case/Model/Behavior/ContainableBehaviorTest.php
	lib/Cake/Test/Case/Model/CakeSchemaTest.php
	lib/Cake/Test/Case/Model/Datasource/Database/PostgresTest.php
	lib/Cake/Test/Case/View/Helper/FormHelperTest.php
	lib/Cake/Test/Case/View/Helper/TimeHelperTest.php
6a4e755
@markstory markstory Fix issue with duplicate associations when using string form.
Fixes #2002
8d43764
@lorenzo lorenzo Making theme test more flexible so it passes after recent changes in …
…templates
a2daa39
@lorenzo lorenzo Typo in last commit. Making flexible the range for memory usage in th…
…eme view after changing internal templates
8ccf904
@lorenzo lorenzo Releasing 2.0.0-RC2 b3157cd
@petteyg petteyg Add validation guess for Postgress inet field 744558d
@lorenzo lorenzo Merge pull request #204 from petteyg/2.0-postgres_inet
2.0 - Add validation guess for Postgress inet field
69934a0
@renan renan Updating cake.generic.css to its newest version from app directory. 1b2b191
@markstory markstory Updating package names in bootstrap file. bfcfeeb
@markstory Jelle Henkens Removing PHP4 compatibility code
Signed-off-by: mark_story <mark@mark-story.com>
957a75c
@markstory markstory Extracting password hashing into as separate method.
This makes is much easier for a subclass to only change how passwords
are hashed.
7cabb4e
@lorenzo lorenzo Fixing doc block in core AppController file b1f8d21
@lorenzo lorenzo Making CakePlugin::loadAll() static as its fellow class methods c45538a
@lorenzo lorenzo Merge branch '2.0' of github.com:cakephp/cakephp into 2.0 90d8667
@daVinciWanaB daVinciWanaB Edited lib/Cake/View/Helper/TextHelper.php via GitHub e50d77f
Contributor

daVinciWanaB commented Sep 21, 2011

Just trying to help, but I think I keep doing it wrong - I just wanted to submit a tiny change to the TextHelper, and it now says I want 3600+ changes or something :/

Owner

lorenzo commented Sep 21, 2011

Don't worry, Try selecting the correct options in the github interface. You need to target the 2.0 branch if you are submitting a patch for 2.0 or 2.3 if it is for the older version. If you keep having troubles I can manually merge your commit after review.

Thanks a lot for contributing!

lorenzo closed this Sep 21, 2011

Contributor

daVinciWanaB commented Sep 21, 2011

I have no idea how to do that - I thought I did a few times - not sure what
the "Correct options" are. Would love to help in the future, but - GitHub
is not intuitive or easy understand for someone not already used to it.

Any suggestions on how to do that would be great - otherwise, having you
manually merging would be great.

Thanks

2011/9/21 Jos Lorenzo Rodrguez <
reply@reply.github.com>

Don't worry, Try selecting the correct options in the github interface. You
need to target the 2.0 branch if you are submitting a patch for 2.0 or 2.3
if it is for the older version. If you keep having troubles I can manually
merge your commit after review.

Thanks a lot for contributing!

Reply to this email directly or view it on GitHub:
#207 (comment)

Owner

lorenzo commented Sep 21, 2011

To be honest, I've never submitted a pull request in the past, so I totally understand you :) I'll try to see if I can come back with some clear instructions

Owner

lorenzo commented Sep 21, 2011

Ok, I figured it out:

  • click on pull request
  • click on the word "cakephp:master" that is on a black box at the top, that will open a set of new options
  • type on the first input "2.0" it will try to autocomplete
  • click on update commit range
  • send the request

I hope this helps

Contributor

daVinciWanaB commented Sep 21, 2011

I must have a different interface than you - I don't see "pull request" anywhere - I do see "Pull Requests" in the menu, but when I click on that, there is no "cakephp:master". Sorry - I'm lost like usual :/

Owner

lorenzo commented Sep 21, 2011

Can you paste a link to a screenshot after you click on "Pull Requests"

Contributor

daVinciWanaB commented Sep 21, 2011

Attached.

(I greatly appreciate your help!)

-Dave

2011/9/21 Jos Lorenzo Rodrguez <
reply@reply.github.com>

Can you paste a link to a screenshot after you click on "Pull Requests"

Reply to this email directly or view it on GitHub:
#207 (comment)

Owner

lorenzo commented Sep 21, 2011

Oops, send a link using a image upload service, I think github does not support email attachments

Contributor

daVinciWanaB commented Sep 21, 2011

Oops - sorry - here it is: http://minus.com/mYwOoGc6H#2

2011/9/21 Jos Lorenzo Rodrguez <
reply@reply.github.com>

Oops, send a link using a image upload service, I think github does not
support email attachments

Reply to this email directly or view it on GitHub:
#207 (comment)

Owner

lorenzo commented Sep 21, 2011

you need to do it from your fork page:

  • Go to your dashboard and select the repo your forked from cakephp
  • Select your patch-2 branch
  • Follow my previous steps

This is how it should look like:

http://cl.ly/1x2N2W2C1k3A1g3G2M06

Owner

lorenzo commented Sep 21, 2011

Remember to click on "Pull Request" at the top, not on "Pull Requests"

Contributor

daVinciWanaB commented Sep 21, 2011

Not sure I'll ever be able to do that again, but - think I got it this time.

Thanks very much for your help!

Dave Schwan
www.daveschwan.com
daveschwan@gmail.com
419-807-1581

2011/9/21 Jos Lorenzo Rodrguez <
reply@reply.github.com>

Remember to click on "Pull Request" at the top, not on "Pull Requests"

Reply to this email directly or view it on GitHub:
#207 (comment)

I believe this should actually have been (ROOT . DS . APP_DIR . DS . 'Config' . DS . 'core.php') as in preceding lookups for bootstrap and tmp

Owner

markstory replied Dec 29, 2012

Why? APP is defined as ROOT . DS . APP_DIR . DS.

APP is actually defined as $this->params['working'] (see line 125), so more error-prone

Contributor

shama replied Dec 29, 2012

@gBokiau Look more closely at the diff. This change does nothing but remove a duplicate constant. Also look how $this->params['working'] is generated: https://github.com/cakephp/cakephp/blob/6e2870c706efe970fae9f239619beededfb39aec/lib/Cake/Console/ShellDispatcher.php#L264

I bumped into this while trying to have the webroot directory on the same level as the app directory, e.g.

ROOT
    APP
    WEBROOT

I figured using the root as working directory and manually defining params['app'] and params['webroot'] would be a solution, even though this could lead to problems further down the road, with APP not being correctly defined.

Not only is this currently impossible, but there is room for two conflicting definitions of the same folder without one taking precedence over the other.

Contributor

shama replied Dec 30, 2012

You're missing the point. How is APP_PATH different than APP in this commit?

Shouldn't that be Cake.Test.Case.View.?
All other cases have Cake.Test.Case.View defined.
I guess that is a leftover from before splitting

Owner

markstory replied May 29, 2013

It really doesn't matter, the package tags aren't used for anything really.

Member

ravage84 replied May 29, 2013

Well, what if someone generates the API docs with something else than https://github.com/cakephp/api_generator ?
For example with ApiGen or phpDocumentator (2).
Those care about the package defs.

Member

ADmad replied May 29, 2013

@ravage84 CakePHP itself uses ApiGen now 😄

Member

ravage84 replied May 29, 2013

Just noticed that i did my remark on the wrong file... should have been lib/Cake/Test/Case/View/ScaffoldViewTest.php.

Fixed it:
#1311

Contributor

davidsteinsland commented on 4a7bd03 Sep 6, 2013

This does not help with the race conditions. The only way to fix the problem is by:

@unlink ($path);

Not even if (file_exists ($path)).

Owner

markstory replied Sep 6, 2013

Thanks, did you want to do a pull request to improve this?

What is this line doing?

Member

ADmad replied Apr 25, 2014

Your guess is good as mine, the commit was done 3 years ago 😄

Member

jippi replied Apr 25, 2014

worst memory ever @ADmad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment