Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added an additional check in TextHelper's autoLinkUrls() #208

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet
6 participants
Contributor

daVinciWanaB commented Sep 21, 2011

will keep it from linking things with 'src=' in front of it.

Owner

markstory commented Sep 21, 2011

Is this to prevent img tags in text?

Contributor

daVinciWanaB commented Sep 21, 2011

If you use autoLink (or autoLinkUrls) on "text" that has any image tags, iframes, embeds...etc, it will attempt to turn the src url into an anchor tag, so you end up with something like: <iframe src="<a href="www.google.com" />"/>

The addition to it makes sureit doesn't convert urls that come after src=" (it's already checking that the url doesn't come after href=")

milesj commented Sep 21, 2011

I usually just make sure there is a whitespace or linebreak before the http://

Contributor

daVinciWanaB commented Sep 22, 2011

milesj: add whitespace or linebreak after src=" ??

Contributor

daVinciWanaB commented Sep 22, 2011

Maybe I did something wrong again? I only wanted to make one tiny change to the TextHelper, and it says I want to commit 10 changes.

Owner

markstory commented Sep 22, 2011

Its because the pull request is targeting the tag instead of the 2.0 branch.

Member

renan commented Sep 26, 2011

Is there any way to edit the pull request to target the 2.0 branch?
If not, can you create another pull?

Closing this one for now.
Thanks so far.

@renan renan closed this Sep 26, 2011

@markstory markstory reopened this Oct 10, 2011

Owner

markstory commented Oct 10, 2011

Since this is a simple change, I can cherry-pick the single commit onto 2.0 and add a test.

markstory added a commit that referenced this pull request Oct 11, 2011

Fix TextHelper::autoLinkUrls() from linking iframes
iframe and img elements should not be autolinked.
Fixes #GH-208
Owner

markstory commented Oct 11, 2011

Merged in [commit db51c05]

@markstory markstory closed this Oct 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment