New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added buffering of form tags generated by FormHelper::postLink() #2274

Merged
merged 1 commit into from Nov 4, 2013

Conversation

Projects
None yet
6 participants
@ADmad
Member

ADmad commented Nov 3, 2013

To avoid nested forms problem.

* Set to false to have the form tag appended to the 'postLink' view block.
* Defaults to true.
* - `block` - Choose a custom block to append the form tag to. Using this option
* will override the inline option.

This comment has been minimized.

@markstory

markstory Nov 3, 2013

Member

Why not only support the block argument instead of having both inline + block?

@markstory

markstory Nov 3, 2013

Member

Why not only support the block argument instead of having both inline + block?

This comment has been minimized.

@ADmad

ADmad Nov 3, 2013

Member

I thought about it but decided to keep inline option to be consistent with other helper functions which have buffering feature. For someone using CakePHP since 1.x it's easy to fall in habit of using inline even when you know about the new block option in 2.x.

@ADmad

ADmad Nov 3, 2013

Member

I thought about it but decided to keep inline option to be consistent with other helper functions which have buffering feature. For someone using CakePHP since 1.x it's easy to fall in habit of using inline even when you know about the new block option in 2.x.

This comment has been minimized.

@markstory

markstory Nov 3, 2013

Member

Ok, I was thinking of removing inline in 3.0, and only having block, but perhaps having both makes the methods easier to use

@markstory

markstory Nov 3, 2013

Member

Ok, I was thinking of removing inline in 3.0, and only having block, but perhaps having both makes the methods easier to use

This comment has been minimized.

@ADmad

ADmad Nov 3, 2013

Member

I don't mind if the inline option is removed across the board in 3.0, just want to keep it in 2.x for consistency.

@ADmad

ADmad Nov 3, 2013

Member

I don't mind if the inline option is removed across the board in 3.0, just want to keep it in 2.x for consistency.

@AD7six

This comment has been minimized.

Show comment
Hide comment
@AD7six

AD7six Nov 3, 2013

Member

👍

Member

AD7six commented Nov 3, 2013

👍

@lorenzo

This comment has been minimized.

Show comment
Hide comment
@lorenzo

lorenzo Nov 4, 2013

Member

how will this affect current 2.4 users?

Member

lorenzo commented Nov 4, 2013

how will this affect current 2.4 users?

@ADmad

This comment has been minimized.

Show comment
Hide comment
@ADmad

ADmad Nov 4, 2013

Member

@lorenzo In no way. It's a backwards compatible feature addition with default behavior being staying same as in 2.4

Member

ADmad commented Nov 4, 2013

@lorenzo In no way. It's a backwards compatible feature addition with default behavior being staying same as in 2.4

@lorenzo

This comment has been minimized.

Show comment
Hide comment
@lorenzo

lorenzo Nov 4, 2013

Member

Cool, I'm merging this

Member

lorenzo commented Nov 4, 2013

Cool, I'm merging this

lorenzo added a commit that referenced this pull request Nov 4, 2013

Merge pull request #2274 from ADmad/feature/postlink-buffer
Added buffering of form tags generated by FormHelper::postLink()

@lorenzo lorenzo merged commit ebd2132 into cakephp:2.5 Nov 4, 2013

1 check passed

default The Travis CI build passed
Details
@ravage84

This comment has been minimized.

Show comment
Hide comment
@ravage84

ravage84 Nov 16, 2013

Member

Could this issue be related?
#1984 <-- great number by the way ;-P

Member

ravage84 commented Nov 16, 2013

Could this issue be related?
#1984 <-- great number by the way ;-P

@ADmad ADmad deleted the ADmad:feature/postlink-buffer branch Nov 16, 2013

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Jul 17, 2014

Member

This has been forgotten to be added to the docs and the 2.5 migration guide it seems.

Member

dereuromark commented Jul 17, 2014

This has been forgotten to be added to the docs and the 2.5 migration guide it seems.

@ADmad

This comment has been minimized.

Show comment
Hide comment
@ADmad
Member

ADmad commented Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment