Skip to content

Removed "PHP 5" from file header DocBlocks #2319

Merged
merged 1 commit into from Nov 14, 2013

5 participants

@ravage84
CakePHP member

This statement does not serve a purpose anymore.
In a long forgotten world it indicated the main version number of PHP which the code in the file was compatible to.
http://pear.php.net/manual/en/standards.sample.php
But since PHP 5.1 and later this is only marginally true.
Thus I propose to remove it from CakePHP.

@ravage84 ravage84 Removed "PHP 5" from file header DocBlocks
This statement does not serve a purpose anymore.
In a long forgotten world it indicated the main version number of PHP which the code in the file was compatible to.
http://pear.php.net/manual/en/standards.sample.php
But since PHP 5.1 and later this is only marginally true.
Thus I propose to remove it from CakePHP.
7cfa011
@dereuromark
CakePHP member

Sounds reasonable.

@Phally
Phally commented Nov 14, 2013

I'm OK with this. 👍

@markstory
CakePHP member

I'm fine with that, I know @lorenzo has been adding PHP Version 5.4 to files in 3.0, but I'd be happy if those went away too.

@lorenzo
CakePHP member
lorenzo commented Nov 14, 2013

I don't mind if those are removed

@markstory markstory merged commit 17ae40f into cakephp:master Nov 14, 2013

1 check passed

Details default The Travis CI build passed
@markstory
CakePHP member

Cool, once the next 2.x -> 3.x merge is done, I'll kill the version headers there.

@ravage84 ravage84 deleted the ravage84:php-5-removal branch Nov 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.