Fixed some copyright and license statements in the file header DocBlocks #2320

Merged
merged 1 commit into from Nov 13, 2013

Projects

None yet

2 participants

Member

These lines were found by using some Regex:

Valid:
* Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
Regex:
\* Copyright (?!\(c\) Cake Software Foundation, Inc\. \(http://cakefoundation\.org\))

Valid:
* Licensed under The MIT License
Regex:
Licensed under (?!The MIT License)

Valid:
* @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
Regex:
@copyright\s*\w(?!opyright \(c\) Cake Software Foundation, Inc\. \(http://cakefoundation\.org\))

Valid:
* @license http://www.opensource.org/licenses/mit-license.php MIT License
Regex:
@license\s*\w(?!ttp://www.opensource.org/licenses/mit-license.php MIT License)

Those regex could be incorporated into the Jenkins Server for example...

@markstory markstory merged commit d8e9f53 into cakephp:master Nov 13, 2013

1 check was pending

default The Travis CI build is in progress
Details
@ravage84 ravage84 deleted the ravage84:copyright+license-fixes branch Nov 13, 2013
Member

@markstory What do you think about including them into the Jenkins Server to ensure future validity?

Owner

Seems reasonable, I guess a simple PHP/bash script that exits 1 when invalid entries are found would work.

Member

Alternatively it could also only report the offences (in a file/page) but not error out.

Owner

Then someone would have to comb through the build output looking for problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment