3.0 more form input #2909

Merged
merged 17 commits into from Feb 28, 2014

Projects

None yet

3 participants

@lorenzo
Owner
lorenzo commented Feb 27, 2014

Fixed more tests for the FormHelper. Related to #2267

Member
ADmad commented Feb 27, 2014

👍

@markstory markstory commented on the diff Feb 27, 2014
tests/TestCase/View/Helper/FormHelperTest.php
@@ -3331,27 +3284,6 @@ public function testFormInputs() {
}
/**
- * Tests inputs() works with plugin models
- *
- * @return void
- */
- public function testInputsPluginModel() {
- $this->markTestIncomplete('Need to revisit once models work again.');
markstory
markstory Feb 27, 2014 Owner

I'm not sure I've specifically included any tests in the ORM context for plugin models. I think that might be something that needs to be solved separately.

lorenzo
lorenzo Feb 27, 2014 Owner

Ok, I guess we can include that test in the entity context. It would work at least if you pass the table key in the context array

markstory
markstory Feb 28, 2014 Owner

Yeah if you pass the table option it will totally work.

@markstory markstory added this to the 3.0.0 milestone Feb 27, 2014
@markstory markstory merged commit 148fd51 into 3.0 Feb 28, 2014

1 check passed

default The Travis CI build passed
Details
@markstory markstory deleted the 3.0-more-form-input branch Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment