Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Property 'name' removed of PagesController. #298

Merged
merged 1 commit into from Jan 18, 2012

Conversation

Projects
None yet
3 participants
Contributor

vitorpacheco commented Nov 5, 2011

No description provided.

Owner

markstory commented Nov 5, 2011

Removing this property means it will need to be calculated on each request, what's the benefit of removing it?

Contributor

vitorpacheco commented Nov 5, 2011

all other controllers are generated without it...
I believe it makes sense, since it was just a hack for php4, if I'm wrong...

Member

ADmad commented Nov 6, 2011

Can't we do without the name property altogether in 2.x?

Owner

markstory commented Nov 6, 2011

Probably, we use name to generate model names and view names, so it can't entirely be removed. But I guess its fine to remove this use of it.

Contributor

vitorpacheco commented Nov 7, 2011

the PagesController not use any model or views (by default)...

@markstory markstory added a commit that referenced this pull request Jan 18, 2012

@markstory markstory Merge pull request #298 from vitorpc/2.0
Property 'name' removed of PagesController.
8608caa

@markstory markstory merged commit 8608caa into cakephp:2.0 Jan 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment