New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Fix Composer package name #3170

Merged
merged 1 commit into from Mar 30, 2014

Conversation

Projects
None yet
3 participants
@renan
Member

renan commented Mar 30, 2014

No description provided.

ADmad added a commit that referenced this pull request Mar 30, 2014

@ADmad ADmad merged commit 3f76b81 into cakephp:3.0 Mar 30, 2014

1 check failed

default The Travis CI build failed
Details
@@ -17,7 +17,7 @@ a starting point. For existing applications you can add the following to your
`composer.json` file:
"require": {
"cakephp/framework": "dev-3.0"
"cakephp/cakephp": "3.0.*-dev"

This comment has been minimized.

@dereuromark

dereuromark Mar 30, 2014

Member

isnt dev- the prefix usually? like in "dev-master", "dev-delopment", ...
So, dev-3.0.*?

@dereuromark

dereuromark Mar 30, 2014

Member

isnt dev- the prefix usually? like in "dev-master", "dev-delopment", ...
So, dev-3.0.*?

@ADmad

This comment has been minimized.

Show comment
Hide comment
@ADmad

ADmad Mar 30, 2014

Member

3.0.*-dev is what currently the app's composer file uses too.

Member

ADmad commented Mar 30, 2014

3.0.*-dev is what currently the app's composer file uses too.

@renan renan deleted the renan:3.0-composer-package branch Mar 30, 2014

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Mar 30, 2014

Member

Yes, I also know that both ways work.
I found the explanation i was looking for, though:

Basically dev releases are now simply branch names with a dev suffix for numeric branches which are comparable (3.0.*-dev) – or a dev prefix for textual names that are not comparable, like feature branches and master (dev-master)

Member

dereuromark commented Mar 30, 2014

Yes, I also know that both ways work.
I found the explanation i was looking for, though:

Basically dev releases are now simply branch names with a dev suffix for numeric branches which are comparable (3.0.*-dev) – or a dev prefix for textual names that are not comparable, like feature branches and master (dev-master)

@renan

This comment has been minimized.

Show comment
Hide comment
@renan

renan Mar 30, 2014

Member

dev-$branch is a composer thing I guess.

To have a dev-3.0 version we need a branch-alias mapping on the composer configuration.

Member

renan commented Mar 30, 2014

dev-$branch is a composer thing I guess.

To have a dev-3.0 version we need a branch-alias mapping on the composer configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment