FormHelper: Allow a boolean value for the disabled attribute in function radio #322

Merged
merged 4 commits into from Mar 4, 2012

Conversation

Projects
None yet
4 participants
@ingk
Contributor

ingk commented Nov 17, 2011

To disable options in a radio button list you can set an array with keys, but it's not possible to set disabled => true to disable all values. In CakePHP 1.x this behavior was present.

@lorenzo

This comment has been minimized.

Show comment Hide comment
@lorenzo

lorenzo Nov 17, 2011

Member

Thanks a lot for your contribution! Do you think you could update the test cases for the FormHelper too?

Member

lorenzo commented Nov 17, 2011

Thanks a lot for your contribution! Do you think you could update the test cases for the FormHelper too?

@ceeram

This comment has been minimized.

Show comment Hide comment
@ceeram

ceeram Nov 17, 2011

Member

Checkbox allows 'disabled' => 'disabled', i think radio should allow that too as valid value perhaps, so i would suggest to change it to something like this:

http://bin.cakephp.org/view/1108501765

Member

ceeram commented Nov 17, 2011

Checkbox allows 'disabled' => 'disabled', i think radio should allow that too as valid value perhaps, so i would suggest to change it to something like this:

http://bin.cakephp.org/view/1108501765

@ingk

This comment has been minimized.

Show comment Hide comment
@ingk

ingk Nov 18, 2011

Contributor

You're right this actually makes more sense.

Contributor

ingk commented Nov 18, 2011

You're right this actually makes more sense.

ingk added a commit to ingk/cakephp that referenced this pull request Nov 24, 2011

@ingk

This comment has been minimized.

Show comment Hide comment
@ingk

ingk Nov 24, 2011

Contributor

I updated the form helper and the test case. Should be fixed now.

Contributor

ingk commented Nov 24, 2011

I updated the form helper and the test case. Should be fixed now.

markstory added a commit that referenced this pull request Mar 4, 2012

Merge pull request #322 from ingk/2.1
FormHelper: Allow a boolean value for the disabled attribute in function radio

@markstory markstory merged commit ca25e75 into cakephp:2.1 Mar 4, 2012

markstory added a commit that referenced this pull request Mar 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment