Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

skipTables for ControllerTask and ViewTask #347

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

petteyg commented Dec 2, 2011

Add skipTables from ModelTask to ControllerTask and ViewTask so that cake bake controller all and cake bake view all will not fail when i18n table exists

@petteyg petteyg referenced this pull request Dec 2, 2011

Closed

skipTables #346

Owner

markstory commented Dec 2, 2011

Couldn't this filtering be done in ModelTask? Then it wouldn't need to be in 2 places.

Contributor

petteyg commented Dec 2, 2011

It is done in ModelTask, so cake bake model all works, but then subsequent cake bake controller all and/or cake bake view all fail.

Owner

markstory commented Dec 4, 2011

Wouldn't having ModelTask::getAllTables() return the filtered results work as well? Then those tables would never be iterated over. There might need to be another parameter for getAllTables() to enable filtering though.

Contributor

petteyg commented Dec 4, 2011

All three tasks had a pretty much identical method for going through the tables, so I just copied the "if i18n" part as the least possible modification. With baked controllers and views being somewhat useless without models, though, I don't see why those tasks need to iterate over tables, rather than just using existing models.

Member

jippi commented Jul 15, 2013

Hi

I'm gonna close this PR as it's 2 years old, and against a branch that is no longer actively developed on

Thanks for the contribution though :)

@jippi jippi closed this Jul 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment