Code consistency formatting tweaks #360

Merged
merged 1 commit into from Dec 7, 2011

Conversation

Projects
None yet
5 participants
Contributor

shama commented Dec 7, 2011

No description provided.

Member

josegonzalez commented Dec 7, 2011

Did you run the cake core through a linter of some sort?

lorenzo added a commit that referenced this pull request Dec 7, 2011

Merge pull request #360 from shama/patch-code-formatting
Code consistency formatting tweaks

@lorenzo lorenzo merged commit dfced8b into cakephp:2.0 Dec 7, 2011

Member

ADmad commented Dec 7, 2011

I bet he has a drone of elves who go through each page manually and make the fixes.

Member

josegonzalez commented Dec 7, 2011

Well there is the code_check shell that could have been upgraded for usage here. https://github.com/petteyg/code_check

Contributor

shama commented Dec 7, 2011

Sadly I'm just using NetBeans find with regex and doing these by hand.

+ * Plugin Short Route class
+ *
+ * @package Cake.Routing.Route
+ */
@markstory

markstory Dec 7, 2011

Owner

We should move the meat in the doc comment above down. This will make that text available in the API.

@shama

shama Dec 7, 2011

Contributor

Ah for some reason I missed those. I felt bad adding poor class docs but thought it was better than nothing. Another pull coming shortly. Thanks Mark!

+ * Redirect Route class
+ *
+ * @package Cake.Routing.Route
+ */
@markstory

markstory Dec 7, 2011

Owner

We should move the meat in the doc comment above down. This will make that text available in the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment