Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Show bind params of prepared statement on sql debug element #460

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

ichikaway commented Feb 4, 2012

I'm using DboSource::fetchAll() for prepared statement.
It shows only sql statement log on the sql debug element.
This patch shows bind value as follows.

select * from posts as Post where Post.id = ? or Post.id = ? , params[ 1, abc ]
select * from posts as Post where Post.id = :id or Post.id = :id2 , params[ id => 1, id2 => 2 ]

Owner

markstory commented Feb 5, 2012

Looks good, I'll probably merge this onto 2.1 instead of 2.0, as we don't normally merge newish things onto 2.0.

Contributor

ichikaway commented Feb 6, 2012

OK :)
May I send pull request to 2.1 repo?

Owner

markstory commented Feb 6, 2012

Sure, or I can cherry-pick the change across. Either one works for me.

@markstory markstory was assigned Feb 7, 2012

Contributor

ichikaway commented Feb 8, 2012

Thanks.
Could you merge it with cherry-pick :)

Owner

markstory commented Feb 9, 2012

Thanks again! Cherry picked in [e8a9d93]

@markstory markstory closed this Feb 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment