Bug fix in TextHelper autoLink #476

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@krolow
Contributor
krolow commented Feb 13, 2012

When you put to autoLink texts, with www in the middle of url, the autoLink was adding the a tag twice... e.g: http://www.not-working-www.com

So I have changed the regex and also add some test to fix that.

@krolow
Contributor
krolow commented Feb 13, 2012

I not sure why the commits 39c6f10 1465b79 comes together but they are not part of the pull request...

@markstory
Member

Do you want to take another stab at making the pull request then? Generally putting each pull request on a separate branch is a good idea. You may need to rebase/make your master the same as CakePHP's master. Lastly, since this is a bugfix you should make the target branch 2.0 and not master.

@markstory markstory closed this Feb 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment