New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model::isUnique() not working as a validator. #4851

Merged
merged 1 commit into from Oct 10, 2014

Conversation

Projects
None yet
3 participants
@markstory
Member

markstory commented Oct 10, 2014

While it did work for single fields, isUnique could not be used to validate the uniqueness across multiple fields as documented. Because validation methods pass arguments in an order the validator did not expect the validation method would not work correctly.

Fixes #4571

Fix Model::isUnique() not working as a validator.
While it *did* work for single fields, isUnique could not be used to
validate the uniqueness across multiple fields as documented. Because
validation methods pass arguments in an order the validator did not
expect the validation method would not work correctly.

Fixes #4571

@markstory markstory added this to the 2.5.6 milestone Oct 10, 2014

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Oct 10, 2014

Member

Cool stuff.
That finally makes it work correctly as documented :)

Member

dereuromark commented Oct 10, 2014

Cool stuff.
That finally makes it work correctly as documented :)

markstory added a commit that referenced this pull request Oct 10, 2014

Merge pull request #4851 from cakephp/issue-4571
Fix Model::isUnique() not working as a validator.

@markstory markstory merged commit 6ee2035 into master Oct 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@markstory markstory deleted the issue-4571 branch Oct 10, 2014

@markstory

This comment has been minimized.

Show comment
Hide comment
@markstory

markstory Oct 10, 2014

Member

Yeah, I'm kind of sad that we had 0 tests for that behavior, but we all thought it worked :(

Member

markstory commented Oct 10, 2014

Yeah, I'm kind of sad that we had 0 tests for that behavior, but we all thought it worked :(

@rchavik

This comment has been minimized.

Show comment
Hide comment
@rchavik

rchavik Oct 13, 2014

Member

Is it possible to make this BC within the 2.5 series? Related croogo/croogo#567

Member

rchavik commented Oct 13, 2014

Is it possible to make this BC within the 2.5 series? Related croogo/croogo#567

@markstory

This comment has been minimized.

Show comment
Hide comment
@markstory

markstory Oct 13, 2014

Member

@rchavik I thought I did, but I guess not. 😢

Member

markstory commented Oct 13, 2014

@rchavik I thought I did, but I guess not. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment