moved docblock on default cache configuration to bootstrap.php, left …
…a note in core.php
moved note about 'default' cache configuration to the APC config docb…
added 'mask' option hint to file cache docblock
Added test for deleting dependent hasMany associated records. Refs #2553
added a further note where to look for available cache implementation…
…s and their respective settings
Merge pull request #416 from 0x20h/move-cache-docblock
Moved cache docblock from core.php to bootstrap.php
Improve the extract to know when there is the same string inside one …
Fix issues with duplicate msgid values.
Msgid values could be duplicated if the same string was used
for singular and pluralized translations. Re-index how the data is
stored so duplicate singular detection per domain is easier.
Made specifying 'extension' optional. Fixed bug where downloaded file…
… did not have extension when 'name' was specified. Fixes #2554
Allow SqlServer to execute procs correctly.
Both SELECT and EXECUTE statements should go through
the parent method as they could fetch results.
with a valley-girl accent? "Exec. u CUTE!"
Bloody hell, I'm a fool. Sorry about that.
Un-derped in [9c1fa28]
Its EXECUTE not EXECUCUTE
Also make the search insensitive as casing bugs are no fun.
Fixing docbloc and adding tests for FormHelper::tagIsInvalid(). Refs …
Add missing options to NumberHelper docblocks
Merge pull request #474 from shama/patch-numberhelper
Added missing echos
Move alias wrapping into _formatAddress()
Fix issues with double / & leading/trailing /
Authorize classes should remove // and leading trailing /
Without this incorrect paths that fail to match nodes can be
generated. This also allows settings[actionPath] to be
permissive in what it accepts.
Fix notice error when reading empty values.
When reading empty values a notice error would be triggered.
Slicing the first char off and comparing that solves this.
Add ics mime type.
Update API docs
View switching only happens for known mime types.
just to make extra sure, probably better to preg_replace('#/+#', '/', $path)
preg_replace('#/+#', '/', $path)
I don't know how you'd end up with 3 slashes though.
I think this was changed by Ceeram not long ago to fix a bug in ACL, he made sure that there was a slash at the beginning of every path. What is the correct way?
In the comments on lighthouse, I thought @ceeram mentioned that the leading slash was a problem. Ticket was http://cakephp.lighthouseapp.com/projects/42648/tickets/2563
i did not change this afaik, the leading slash indeed causes issues, i discussed that a while back already in irc, it is fine as it is now
me too @markstory. But I thought as $path is a parameter it would probably make sense to be a bit more fault-tolerant. But, of course, it's ok as it is.
Remove pointless comparison.
fixing regex of autoLinks to work with urls that have www
Merge pull request #477 from krolow/ticket-2574
Fix duplicate items in HABTM associations.
Apply patch from 'Kim Biesbjerg'. Fixes issues where nested
HABTM associations would create duplicate content.
Add failing tests for patches from 'teddyzeenny'.
urldecode custom route element values
urldecode $this->url before unsetting it from CakeRequest->query
Fix failing tests.
rawurlencode() and urlencode() handle utf8 differently.
Update the Set::merge() documentation.
Remove un-necessary Set::merge().
Using Set::merge() on an empty array causes issues with out of order
numeric keys. Only merge if necessary.
git bisect shows this commit as introduding duplicate values when posting habtm data with input('Tag') on a Post form.
request->data['Tag']['Tag'] should be array(1, 2), but now shows array(1, 2, 1, 2) when selecting first 2 tags
created a testcase for this, not sure how to solve it yet, need to look into that
included a fix now as well
I'm an idiot, I don't know how I missed that the first time around. I merged in your changes :D
@markstory Your original commit was on 2.0 so perhaps the fix done by Ceeram for 2.1 should be backported to 2.0 too.
It certainly should. I cherry-picked the changes in [836f913] and [6d3c659]
commented in wrong place already i think
@markstory The branch had 4 commits in total for the tests and fix, i messed up with making tests
you only cherry-picked two of the commits in 2.0, causing a fail
Thanks, I guess I'll find the other commits and merge those too.
testcase for incorrect merge of post data
fixed expected and result order in asserts, also added extra test
@markstory the branch which fixed the issue had 4 commits, you only merged 2 of them to 2.0 causing a fail
another attempy to set correc order for expected and result in assert…
…, definitely time for some coffee
fixing incorrect post data
Please, do not send pull request agains out master branch, use an appropriate branch.
I tried, but could not pull request on 2.0 and 2.1 branch