fixed ticket #989, Set::extract replacing first index with an index of same key #53

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@torifat
Contributor

torifat commented Apr 18, 2011

fixed ticket #989, Set::extract replacing first index with an index of same key [0] one step lower fixed

Passed 'libs / Set' tests.

http://cakephp.lighthouseapp.com/projects/42648/tickets/989-setextract-replacing-first-index-with-an-index-of-same-key-0-one-step-lower

@markstory

This comment has been minimized.

Show comment Hide comment
@markstory

markstory Apr 27, 2011

Owner

Why does this change re-indent the whole file? It makes it impossible to see what actually changed and using spaces for indentation is not in the CakePHP code style. Sorry, but diffing the whole file and busting up the whitespace means I can't accept this patch.

Owner

markstory commented Apr 27, 2011

Why does this change re-indent the whole file? It makes it impossible to see what actually changed and using spaces for indentation is not in the CakePHP code style. Sorry, but diffing the whole file and busting up the whitespace means I can't accept this patch.

@torifat

This comment has been minimized.

Show comment Hide comment
@torifat

torifat Apr 27, 2011

Contributor

yeah, got you. sorry its due to my editor. I'll submit a fresh one.

Contributor

torifat commented Apr 27, 2011

yeah, got you. sorry its due to my editor. I'll submit a fresh one.

@torifat torifat closed this Apr 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment