Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating form tag without "action" attribute. #6490

Merged
merged 3 commits into from May 7, 2015
Merged

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented May 5, 2015

Closes #6488

@ADmad ADmad added this to the 3.0.4 milestone May 5, 2015
@@ -674,6 +674,26 @@ public function testCreateAutoUrl()
}

/**
* test create() with no url (no "action" attribute for <form> tag)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: URL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick on nitpick: you missed mentioning the missing capital T (beginning of sentence).

@dereuromark
Copy link
Member

👍

markstory added a commit that referenced this pull request May 7, 2015
Allow creating form tag without "action" attribute.
@markstory markstory merged commit bb9ff25 into master May 7, 2015
@markstory markstory deleted the issue-6488 branch May 7, 2015 01:15
markstory added a commit that referenced this pull request May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x FormHelper no way to create form without action
4 participants