Better custom find for pagination #723

Merged
merged 1 commit into from Jul 19, 2012

4 participants

@jippi
CakePHP member

Instead of shuffling the paginator settings you can now simply add a new "findType" key and it will automatically change the find() type accordingly

@lorenzo
CakePHP member

+1 One of the most annoying things about constructing pagination options on the fly is injecting a custom find value, as you have to array_shift() the original array. It would be a lot more consistent to have an array key like everything else on this array.

customFind sounds like a good choice for such a key as it is unlikely it would colide with others used for pagination

@rodrigorm

Why not just a 'find' key? Sounds more reasonable.

@jippi jippi Better custom find for pagination
Instead of shuffling the paginator settings you can now simply add a new "findType" key and it will automatically change the find() type accordingly
bce82a2
@lorenzo
CakePHP member

Or findType :P

@jippi
CakePHP member

Updated the key to "findType"

@markstory
CakePHP member

+1 for findType as well.

@lorenzo
CakePHP member

I'll get this merged in, then

@lorenzo lorenzo merged commit 2ccbf78 into cakephp:2.3 Jul 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment