allow between to be an array of strings #864

merged 3 commits into from Jan 25, 2013


None yet
2 participants

markstory commented Sep 21, 2012

What happens when there are fewer elements in the 'between' array than there are radio buttons?


dereuromark commented Sep 21, 2012

I'd say that is the developer's fault. just as if you pass an array into sth that is supposed to be a string etc.
right now it would not diplay any errors and silently display only the ones provided so far.


dereuromark commented Oct 25, 2012

any objections? is is this good?


markstory commented Oct 25, 2012

I think you're still missing tests for the behaviour when there are fewer elements in the between option then there are radio options.


dereuromark commented Oct 26, 2012

no, I added one with 7aa78c4


dereuromark commented Nov 27, 2012

do you want me to write a more verbose one? because the previous requirements have been met - as linked above.


markstory commented Nov 28, 2012

Ah so you did.


dereuromark commented Jan 25, 2013

May I (or anybody else) merge then? I itch to use it :-)

@markstory markstory added a commit that referenced this pull request Jan 25, 2013

@markstory markstory Merge pull request #864 from dereuromark/2.3-radio-multiple-between
allow between to be an array of strings

Fixes #2859

@markstory markstory merged commit bc4db91 into cakephp:2.3 Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment