move charset/App.encoding into CakeResponse #871

merged 1 commit into from Sep 28, 2012


None yet

4 participants

CakePHP member

Request/Reponse should handle the default for charset itself.

Currently there are places where the CakeResponse object would be created without proper charset setting due to the forgotten param passed on (ExceptionRenderer::_getController() and RedirectRoute::parse() for example). This PR unifies those two different behaviors making them consistent and correct throughout the core and apps.

It is not only cleaner (and less error producing) to do this internally, but also makes creating the object easier and more straight-forward. not only for test cases.

CakePHP member

I like this.

CakePHP member

Looks reasonable

CakePHP member

I like this as well. Its a reasonable default and doesn't modify existing behavior

@markstory markstory merged commit 9c78aae into cakephp:2.3 Sep 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment