Added View::startIfEmpty($name) #929

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

LiquidityC commented Oct 29, 2012

Ticket: #3315

Adds method startIfEmpty to ViewBlock and View allowing the developer to add content to a block only if it has no content from previously rendered Views/Layouts

Owner

markstory commented Oct 30, 2012

This looks like it will work much better, we just need to add some test cases to ensure things are working and stay working.

Member

ADmad commented Oct 30, 2012

This PR needs to be against the 2.3 branch instead of master.

Contributor

LiquidityC commented Oct 30, 2012

Ok, I'll write some tests then?

Do I have to close this PR and create a new one against 2.3? Or is it possible to move it?

Member

ADmad commented Oct 30, 2012

The easiest option would probably be create a new local bug fix branch from the 2.3 branch, cherry pick your commit onto that bugfix branch and create new PR against 2.3 branch.

Contributor

LiquidityC commented Oct 30, 2012

Ok, new PR. I'll fix it. I'll look over the tests aswell and see what I can do.

@LiquidityC LiquidityC closed this Oct 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment