Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

3.0 request action #939

Merged
merged 7 commits into from Nov 7, 2012

Conversation

Projects
None yet
2 participants
Owner

markstory commented Nov 3, 2012

Extract requestAction() into a trait. This lets us limit the number of places that its exposed by default, and give people the option to add it in where they need it later on.

Member

jrbasso commented Nov 4, 2012

I guess you should add the trait in the Cake\View\View as well, to use in the ctp files. Leaving the current functionality.

@jrbasso jrbasso and 1 other commented on an outdated diff Nov 4, 2012

...Cake/Controller/Component/RequestHandlerComponent.php
@@ -43,6 +44,8 @@
*/
class RequestHandlerComponent extends Component {
+ use RequestActionTrait;
@jrbasso

jrbasso Nov 4, 2012

Member

Can't you use thru controller?

@markstory

markstory Nov 5, 2012

Owner

True, I'll fix that and the omission in View\View.

@markstory markstory Remove requestAction from RequestHandlerComponent.
The method is available on the controller objects. Use that instead.
0930645

@markstory markstory commented on the diff Nov 5, 2012

lib/Cake/View/View.php
@@ -64,6 +65,8 @@
*/
class View extends Object {
+ use RequestActionTrait;
Owner

markstory commented Nov 6, 2012

If there aren't any other comments on this, I'll merge it in tomorrow and update the documentation for 3.0

Member

jrbasso commented Nov 6, 2012

👍

@markstory markstory added a commit that referenced this pull request Nov 7, 2012

@markstory markstory Merge pull request #939 from markstory/3.0-request-action
3.0 request action
c401b81

@markstory markstory merged commit c401b81 into cakephp:3.0 Nov 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment