fix remaining cs errors #940

Merged
merged 1 commit into from Nov 4, 2012

Projects

None yet

5 participants

@ceeram
Member
ceeram commented Nov 4, 2012

No description provided.

Member

can we - by any chance - deprecate the ":" and "endforeach;" stuff in favor of the "{}" brackets?
the latter is way better to use in IDEs since you can highlight the end of the conditional block. this doesnt work with the first.

so

<?php foreach ($plugins as $plugin): ?>

would be

<?php foreach ($plugins as $plugin) { ?>

as pretty much everywhere else, as well.

same thing then goes for "if" and "while" etc.

Member
ceeram commented Nov 4, 2012

: and endforeach; is used in view templates only normally. The one included in these changes, is testsuite menu.
Also a good editor understand the : and endforeach; :)

Member
ceeram commented Nov 4, 2012

@dereuromark create google group post for the other discussion

Member
ADmad commented Nov 4, 2012

@ceeram I would be surprised if the change proposed by @dereuromark gets any vote other than his own 😄

Owner
lorenzo commented Nov 4, 2012

I vote no

@lorenzo lorenzo merged commit c7f2a64 into cakephp:master Nov 4, 2012
Owner

@dereuromark All I have to say is that <?php } ?> is about the hardest thing to understand in all of PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment